Bug 192470

Summary: REGRESSION: run-webkit-tests may fail when using booted simulators
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, lforschler, rniwa, ryanhaddad, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192161
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2018-12-06 12:38:58 PST
There are a few edge-cases with <https://bugs.webkit.org/show_bug.cgi?id=192161> when simulators are already booted that the existing code does not cover.
Attachments
Patch (5.78 KB, patch)
2018-12-06 13:22 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (9.79 KB, patch)
2018-12-06 14:11 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-06 12:39:34 PST
<rdar://problem/46532001>
Jonathan Bedard
Comment 2 2018-12-06 13:22:23 PST
Created attachment 356745 [details] Patch
Ryosuke Niwa
Comment 3 2018-12-06 13:32:39 PST
Comment on attachment 356745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356745&action=review Can we add a test for this? > Tools/Scripts/webkitpy/port/device_port.py:134 > + if result != 0 and self.DEVICE_MANAGER == SimulatedDeviceManager: Nit: We don't compare against 0 per our style guideline.
Jonathan Bedard
Comment 4 2018-12-06 13:45:02 PST
(In reply to Ryosuke Niwa from comment #3) > Comment on attachment 356745 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356745&action=review > > Can we add a test for this? > ... > Not for all of it (anything that interfaces with simctl or actual devices is difficult to test in a cross-platform manner) , but I'll definitely include some.
Jonathan Bedard
Comment 5 2018-12-06 14:11:57 PST
Created attachment 356753 [details] Patch
WebKit Commit Bot
Comment 6 2018-12-06 15:21:40 PST
Comment on attachment 356753 [details] Patch Clearing flags on attachment: 356753 Committed r238944: <https://trac.webkit.org/changeset/238944>
WebKit Commit Bot
Comment 7 2018-12-06 15:21:42 PST
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 8 2018-12-07 13:15:20 PST
Committed r238966: <https://trac.webkit.org/changeset/238966>
Note You need to log in before you can comment on or make changes to this bug.