| Summary: | REGRESSION: run-webkit-tests may fail when using booted simulators | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, glenn, lforschler, rniwa, ryanhaddad, slewis, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=192161 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2018-12-06 12:38:58 PST
Created attachment 356745 [details]
Patch
Comment on attachment 356745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356745&action=review Can we add a test for this? > Tools/Scripts/webkitpy/port/device_port.py:134 > + if result != 0 and self.DEVICE_MANAGER == SimulatedDeviceManager: Nit: We don't compare against 0 per our style guideline. (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 356745 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356745&action=review > > Can we add a test for this? > ... > Not for all of it (anything that interfaces with simctl or actual devices is difficult to test in a cross-platform manner) , but I'll definitely include some. Created attachment 356753 [details]
Patch
Comment on attachment 356753 [details] Patch Clearing flags on attachment: 356753 Committed r238944: <https://trac.webkit.org/changeset/238944> All reviewed patches have been landed. Closing bug. Committed r238966: <https://trac.webkit.org/changeset/238966> |