Summary: | [meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Component: | WebKit2 | Assignee: | chris fleizach <cfleizach> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | cfleizach, commit-queue, darin, dbates, ews-watchlist, jlewis3, magomez, mkwst, ryanhaddad, thorton, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug Depends on: | 192450, 191995, 192301, 192352, 192588, 192968 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Fujii Hironori
2018-12-05 20:09:40 PST
Grepped remaining using namespace in the global scope. https://gist.github.com/fujii/869707c181ca78fd4d9faaf03fbca832 https://lists.webkit.org/pipermail/webkit-dev/2018-December/030289.html > I'm hitting this tougher one now. Namespace conflict between Rect in Carbon and WebCore::Rect I almost have this one fixed in the other bug to at least get this building But I'm still stuck on this one issue In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:6: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:32: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModule.h:34: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npruntime_internal.h:28: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npapi.h:82: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Headers/Carbon.h:29: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbox.h:35: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbar.h:26: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Menus.h:22: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Appearance.h:1373:3: error: reference to 'Rect' is ambiguous Rect bounds; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/WebKit2Prefix.h:45: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:43: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:77: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:550:41: note: candidate found by name lookup is 'Rect' typedef struct Rect Rect; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:79: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/AXObjectCache.h:29: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/AccessibilityObject.h:33: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/HTMLTextFormControlElement.h:27: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/HTMLFormControlElementWithState.h:26: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/HTMLFormControlElement.h:28: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/LabelableElement.h:33: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/HTMLElement.h:30: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/StyledElement.h:27: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/CSSPrimitiveValue.h:45:7: note: candidate found by name lookup is 'WebCore::Rect' class Rect; ^ (In reply to chris fleizach from comment #4) > But I'm still stuck on this one issue > > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified- > sources/UnifiedSource28-mm.mm:6: > In file included from > /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Plugins/mac/ > PluginInfoStoreMac.mm:32: > In file included from > /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/Plugins/Netscape/ > NetscapePluginModule.h:34: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/npruntime_internal.h:28: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/npapi.h:82: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/ > Headers/Carbon.h:29: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/ > Frameworks/HIToolbox.framework/Headers/HIToolbox.h:35: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/ > Frameworks/HIToolbox.framework/Headers/HIToolbar.h:26: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/ > Frameworks/HIToolbox.framework/Headers/Menus.h:22: > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/ > Frameworks/HIToolbox.framework/Headers/Appearance.h:1373:3: error: reference > to 'Rect' is ambiguous > Rect bounds; > ^ > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified- > sources/UnifiedSource28-mm.mm:1: > In file included from > /Volumes/Data/EWS/WebKit/Source/WebKit/WebKit2Prefix.h:45: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation. > framework/Headers/CoreFoundation.h:43: > In file included from > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation. > framework/Headers/CFBase.h:77: > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/ > Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:550:41: note: > candidate found by name lookup is 'Rect' > typedef struct Rect Rect; > ^ > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified- > sources/UnifiedSource28-mm.mm:1: > In file included from > /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:79: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/AXObjectCache.h:29: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/AccessibilityObject.h:33: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/HTMLTextFormControlElement.h:27: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/HTMLFormControlElementWithState.h:26: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/HTMLFormControlElement.h:28: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/LabelableElement.h:33: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/HTMLElement.h:30: > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/StyledElement.h:27: > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/ > PrivateHeaders/CSSPrimitiveValue.h:45:7: note: candidate found by name > lookup is 'WebCore::Rect' > class Rect; > ^ Can't figure out who' responsible You need to get a copy of UnifiedSource28-mm.mm from a failing machine, open all of the things it includes, and find the misplaced (in the root) 'using namespace WebCore'. (In reply to Tim Horton from comment #6) > You need to get a copy of UnifiedSource28-mm.mm from a failing machine, open > all of the things it includes, and find the misplaced (in the root) 'using > namespace WebCore'. working on it... hopefully will have this ready tonight Created attachment 356865 [details]
patch
Created attachment 356866 [details]
patch
Created attachment 356867 [details]
patch
Created attachment 356868 [details]
patch
Created attachment 356869 [details]
patch
Attachment 356869 [details] did not pass style-queue:
ERROR: Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:84: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 57 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 356870 [details]
patch
Created attachment 356871 [details]
patch
Created attachment 356872 [details]
patch
Comment on attachment 356872 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=356872&action=review > Source/WebKit/UIProcess/ios/WKContentView.mm:65 > using namespace WebKit; This is still a potential problem. Needs to eventually be removed. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:145 > using namespace WebKit; This is still a potential problem. Needs to eventually be removed. > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:61 > +using namespace WebKit; This is still a potential problem. Needs to eventually be removed. > Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:40 > using namespace WebKit::CacheStorage; This is now a bit peculiar. Should probably just say "using namespace CacheStorage". > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:51 > using namespace WebKit; This is still a potential problem. Needs to eventually be removed. (In reply to Darin Adler from comment #17) > Comment on attachment 356872 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356872&action=review > > > Source/WebKit/UIProcess/ios/WKContentView.mm:65 > > using namespace WebKit; > > This is still a potential problem. Needs to eventually be removed. > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:145 > > using namespace WebKit; > > This is still a potential problem. Needs to eventually be removed. > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:61 > > +using namespace WebKit; > > This is still a potential problem. Needs to eventually be removed. > > > Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:40 > > using namespace WebKit::CacheStorage; > > This is now a bit peculiar. Should probably just say "using namespace > CacheStorage". > > > Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:51 > > using namespace WebKit; > > This is still a potential problem. Needs to eventually be removed. I'll fix up these cases. thanks Created attachment 356908 [details]
patch
Created attachment 356926 [details]
patch
Created attachment 356929 [details]
patch
Created attachment 356950 [details]
patch
Created attachment 356951 [details]
patch
Comment on attachment 356951 [details] patch Clearing flags on attachment: 356951 Committed r239029: <https://trac.webkit.org/changeset/239029> All reviewed patches have been landed. Closing bug. Created attachment 356989 [details]
patch
Reverted r239029 for reason: This patch caused internal build failures. Committed r239047: <https://trac.webkit.org/changeset/239047> (In reply to Matt Lewis from comment #28) > Reverted r239029 for reason: > > This patch caused internal build failures. > > Committed r239047: <https://trac.webkit.org/changeset/239047> I just put up a patch to fix this hidden issue. Created attachment 356993 [details]
patch
Created attachment 356995 [details]
patch
Created attachment 357000 [details]
patch
Comment on attachment 357000 [details] patch Attachment 357000 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10343817 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html Created attachment 357014 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 357000 [details] patch Rejecting attachment 357000 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 357000, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: raction.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm ERROR from SVN: Merge conflict during commit: Conflict at '/trunk/Source/WebKit/ChangeLog' W: 98abe06ceec970ee6ada7b87ad4d21418585658e and refs/remotes/origin/master differ, using rebase: :040000 040000 3d204e3ffe60e8f41e90be7e6ac87da08c215f3c 34e0b6937af094eccc26097e05a7b2081e03bf42 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/NetworkProcess/Cookies/mac/WebCookieManagerMac.mm M Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp M Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm M Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm M Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm M Source/WebKit/PluginProcess/PluginControllerProxy.cpp M Source/WebKit/PluginProcess/PluginProcess.cpp M Source/WebKit/PluginProcess/WebProcessConnection.cpp M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb M Source/WebKit/Shared/API/c/cf/WKErrorCF.cpp M Source/WebKit/Shared/API/c/cg/WKImageCG.cpp M Source/WebKit/Shared/ChildProcess.cpp M Source/WebKit/Shared/ContextMenuContextData.cpp M Source/WebKit/Shared/EditorState.cpp M Source/WebKit/Shared/Plugins/NPIdentifierData.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp M Source/WebKit/Shared/SessionState.cpp M Source/WebKit/Shared/SessionTracker.cpp M Source/WebKit/Shared/ShareableBitmap.cpp M Source/WebKit/Shared/ShareableResource.cpp M Source/WebKit/Shared/VisibleContentRectUpdateInfo.cpp M Source/WebKit/Shared/WebBackForwardListItem.cpp M Source/WebKit/Shared/WebContextMenuItemData.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebHitTestResultData.cpp M Source/WebKit/Shared/WebImage.cpp M Source/WebKit/Shared/WebMediaSessionMetadata.cpp M Source/WebKit/Shared/WebMemorySampler.cpp M Source/WebKit/Shared/WebMouseEvent.cpp M Source/WebKit/Shared/WebRenderObject.cpp M Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp M Source/WebKit/Shared/WebWheelEvent.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/ios/WebPlatformTouchPointIOS.cpp M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp M Source/WebKit/UIProcess/API/APIHitTestResult.cpp M Source/WebKit/UIProcess/API/APINavigation.cpp M Source/WebKit/UIProcess/API/APIOpenPanelParameters.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/C/WKContext.cpp M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/cg/WKIconDatabaseCG.cpp M Source/WebKit/UIProcess/Cocoa/WebViewImpl.h M Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm M Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp M Source/WebKit/UIProcess/ios/WKContentView.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm M Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm ERROR from SVN: Merge conflict during commit: Conflict at '/trunk/Source/WebKit/ChangeLog' W: 98abe06ceec970ee6ada7b87ad4d21418585658e and refs/remotes/origin/master differ, using rebase: :040000 040000 3d204e3ffe60e8f41e90be7e6ac87da08c215f3c 34e0b6937af094eccc26097e05a7b2081e03bf42 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/10344778 Created attachment 357021 [details]
patch
Comment on attachment 357021 [details] patch Clearing flags on attachment: 357021 Committed r239071: <https://trac.webkit.org/changeset/239071> All reviewed patches have been landed. Closing bug. This broke the build of WPE as now the definitions of toImpl and toAPI are not found on WKContext.cpp and WKPage.cpp. I understand bug 192450 will deal with toImpl, but we need to take care of toAPI as well. Re-opened since this is blocked by bug 192588 Created attachment 357109 [details]
patch
Created attachment 357112 [details]
patch
Comment on attachment 357112 [details] patch Attachment 357112 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10363789 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html Created attachment 357115 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 357136 [details]
patch
Given we are having so much trouble landing this, maybe we can land it in smaller pieces, so we only have to roll out the one that causes breakage? Seems almost every single one of these changes stands alone. (In reply to Darin Adler from comment #46) > Given we are having so much trouble landing this, maybe we can land it in > smaller pieces, so we only have to roll out the one that causes breakage? > Seems almost every single one of these changes stands alone. Ok Created attachment 357139 [details]
patch - part1
(In reply to chris fleizach from comment #47) > (In reply to Darin Adler from comment #46) > > Given we are having so much trouble landing this, maybe we can land it in > > smaller pieces, so we only have to roll out the one that causes breakage? > > Seems almost every single one of these changes stands alone. > > Ok harder than it seems, since putting things inside namespaces changes other callsites Created attachment 357145 [details]
patch, part 1
Comment on attachment 357145 [details]
patch, part 1
wincairo, gtk and iOS-sim test unrelated
Comment on attachment 357145 [details] patch, part 1 Clearing flags on attachment: 357145 Committed r239124: <https://trac.webkit.org/changeset/239124> All reviewed patches have been landed. Closing bug. Created attachment 357152 [details]
patch, part 2
Doing this patch in parts, keeping open Comment on attachment 357152 [details] patch, part 2 Clearing flags on attachment: 357152 Committed r239128: <https://trac.webkit.org/changeset/239128> All reviewed patches have been landed. Closing bug. Created attachment 357189 [details]
patch, part 3
Build fix for iOSmac
Created attachment 357191 [details]
patch, part 4
Created attachment 357195 [details]
patch, part 5
Reopening since more patches are being attached for landing. The commit queue ignores bugs in the resolved state. Comment on attachment 357189 [details] patch, part 3 Clearing flags on attachment: 357189 Committed r239140: <https://trac.webkit.org/changeset/239140> All reviewed patches have been landed. Closing bug. keeping open Comment on attachment 357191 [details] patch, part 4 Clearing flags on attachment: 357191 Committed r239143: <https://trac.webkit.org/changeset/239143> All reviewed patches have been landed. Closing bug. More to comr Comment on attachment 357195 [details] patch, part 5 Clearing flags on attachment: 357195 Committed r239148: <https://trac.webkit.org/changeset/239148> All reviewed patches have been landed. Closing bug. Created attachment 357211 [details]
patch, part 6
Created attachment 357214 [details]
patch, part 7
patches to come Created attachment 357218 [details]
patch, part 6
Comment on attachment 357218 [details] patch, part 6 Clearing flags on attachment: 357218 Committed r239166: <https://trac.webkit.org/changeset/239166> All reviewed patches have been landed. Closing bug. more patches Created attachment 357232 [details]
patch, part 7
Comment on attachment 357232 [details] patch, part 7 Attachment 357232 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10385156 New failing tests: webanimations/leak-document-with-web-animation.html Created attachment 357237 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 357278 [details]
patch - part7
Created attachment 357318 [details]
patch - part7
Created attachment 357329 [details]
patch, part 7
try patch again to get all the bots going
Comment on attachment 357329 [details] patch, part 7 Clearing flags on attachment: 357329 Committed r239258: <https://trac.webkit.org/changeset/239258> All reviewed patches have been landed. Closing bug. |