Bug 192430

Summary: Move more macros out of WebKit's config.h
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Alexey Proskuryakov
Reported 2018-12-05 14:46:24 PST
Save some bug IDs by moving multiple macros at once!
Attachments
proposed patch (3.57 KB, patch)
2018-12-05 14:49 PST, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-12-05 14:49:26 PST
Created attachment 356662 [details] proposed patch These all seem straightforward. Removing ifndefs, removing #else clauses, simplifying some of the conditions.
Tim Horton
Comment 2 2018-12-07 15:09:14 PST
Comment on attachment 356662 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356662&action=review > Source/WTF/wtf/Platform.h:1426 > +#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC) Cocoa
Alexey Proskuryakov
Comment 3 2018-12-10 09:55:50 PST
Committed http://trac.webkit.org/r239034
Radar WebKit Bug Importer
Comment 4 2018-12-10 09:56:21 PST
<rdar://problem/46598583>
Note You need to log in before you can comment on or make changes to this bug.