Bug 192426

Summary: Move USE_NEW_THEME out of WebCore's config.h
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, rniwa, simon.fraser, thorton, timothy, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
Archive of layout-test-results from ews101 for mac-sierra none

Alexey Proskuryakov
Reported 2018-12-05 14:10:19 PST
Platform specific USE macros live in Platform.h, not here.
Attachments
proposed patch (2.36 KB, patch)
2018-12-05 14:11 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.41 MB, application/zip)
2018-12-05 19:56 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-12-05 14:11:43 PST
Created attachment 356655 [details] proposed patch
EWS Watchlist
Comment 2 2018-12-05 19:56:44 PST
Comment on attachment 356655 [details] proposed patch Attachment 356655 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10286800 New failing tests: http/tests/misc/resource-timing-resolution.html
EWS Watchlist
Comment 3 2018-12-05 19:56:46 PST
Created attachment 356702 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Alexey Proskuryakov
Comment 4 2018-12-06 12:54:55 PST
Test failure is unrelated.
Tim Horton
Comment 5 2018-12-06 13:51:11 PST
Comment on attachment 356655 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356655&action=review > Source/WTF/wtf/Platform.h:1427 > +/* FIXME: This really needs a descriptive name, this "new theme" was added in 2008. */ Agreed! And the refactor wasn't even completed, so this is really a bit of a mess.
WebKit Commit Bot
Comment 6 2018-12-06 21:51:39 PST
Comment on attachment 356655 [details] proposed patch Clearing flags on attachment: 356655 Committed r238949: <https://trac.webkit.org/changeset/238949>
WebKit Commit Bot
Comment 7 2018-12-06 21:51:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-12-06 21:53:00 PST
<rdar://problem/46546186>
Note You need to log in before you can comment on or make changes to this bug.