| Summary: | Remove unused API in NetworkProcess | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, ews-watchlist, rniwa, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | Other | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Rob Buis
2018-12-05 11:23:49 PST
Created attachment 356627 [details]
Patch
Comment on attachment 356627 [details] Patch Attachment 356627 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10281139 New failing tests: http/tests/inspector/network/har/har-page.html http/tests/inspector/network/resource-request-headers.html Created attachment 356641 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 356627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356627&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:-529 > - m_bytesReceived += buffer->size(); Why are you changing this line? (In reply to Ryosuke Niwa from comment #4) > Comment on attachment 356627 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356627&action=review > > > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:-529 > > - m_bytesReceived += buffer->size(); > > Why are you changing this line? m_bytesReceived keeps being written to, but nobody reads it, so I think it is pointless. It seems m_numBytesReceived has taken its place. Note that my patch is not final, I'll keep scanning for more API that can be removed, and will put up something for review later this week. Created attachment 356806 [details]
Patch
Created attachment 356807 [details]
Patch
Created attachment 356812 [details]
Patch
Created attachment 356817 [details]
Patch
Comment on attachment 356817 [details] Patch Clearing flags on attachment: 356817 Committed r239007: <https://trac.webkit.org/changeset/239007> All reviewed patches have been landed. Closing bug. |