Bug 192403

Summary: Add some sanity checks inside WebBackForwardList::addItem()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, beidson, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2018-12-05 09:18:58 PST 
Add some sanity checks inside WebBackForwardList::addItem() to help debug <rdar://problem/46399319>. This crash seems to indicate that WebBackForwardList::m_entries can contain duplicate entries somehow.
Comment 1 Chris Dumez 2018-12-05 09:19:58 PST 
Created attachment 356611 [details]
Patch
Comment 2 EWS Watchlist 2018-12-05 09:22:08 PST 
Attachment 356611 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.