Bug 192390

Summary:

Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Matt Baker

Reported 2018-12-04 18:13:57 PST

Summary: SelectionController should not extend the selection when allowsMultipleSelection is false. Note: It isn't possible to circumvent the `allowsMultipleSelection` flag using the UI (by shift/command-clicking). This change will prevent circumventing the flag by setting `extendSelection = true` when calling `SelectionController.prototype.selectItem`.

Attachments
Patch (5.50 KB, patch) 2018-12-04 18:21 PST, Matt Baker	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-12-04 18:14:31 PST

<rdar://problem/46473624>

Matt Baker

Comment 2 2018-12-04 18:21:46 PST

Created attachment 356567 [details] Patch

Devin Rousso

Comment 3 2018-12-05 15:24:28 PST

Comment on attachment 356567 [details] Patch r=me

WebKit Commit Bot

Comment 4 2018-12-05 15:50:16 PST

Comment on attachment 356567 [details] Patch Clearing flags on attachment: 356567 Committed r238914: <https://trac.webkit.org/changeset/238914>

WebKit Commit Bot

Comment 5 2018-12-05 15:50:17 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.