Bug 192378

Summary: Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
Product: WebKit Reporter: Suresh Koppisetty <skoppisetty>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, rniwa, skoppisetty, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Mac   
OS: macOS 10.14   
Attachments:
Description Flags
Patch none

Suresh Koppisetty
Reported 2018-12-04 14:12:21 PST
FeedbackServer currently depends on Tornado-5.1, which further adds dependency of "singledispatch", "backports-abc" and "futures" python libraries. Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled will let us run the benchmark scripts without installing any new python libraries.
Attachments
Patch (2.25 KB, patch)
2018-12-04 14:28 PST, Suresh Koppisetty 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Suresh Koppisetty
Comment 1 2018-12-04 14:28:14 PST
Created attachment 356534 [details] Patch
WebKit Commit Bot
Comment 2 2018-12-17 15:01:52 PST
Comment on attachment 356534 [details] Patch Clearing flags on attachment: 356534 Committed r239292: <https://trac.webkit.org/changeset/239292>
WebKit Commit Bot
Comment 3 2018-12-17 15:01:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-17 15:02:59 PST
<rdar://problem/46791637>
Note You need to log in before you can comment on or make changes to this bug.