Bug 192358

Summary: Always pass scrollingGeometry to update*ScrollingNode functions
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: New BugsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176454, 172917    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Frédéric Wang (:fredw) 2018-12-04 03:03:41 PST
Always pass scrollingGeometry to update*ScrollingNode functions
Comment 1 Frédéric Wang (:fredw) 2018-12-04 03:04:25 PST
Created attachment 356478 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-12-04 03:27:56 PST
Created attachment 356481 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2018-12-04 11:07:33 PST
Created attachment 356517 [details]
Patch

I'm not sure how much this is aligned / conflicting with your work, but I wonder whether we could take this so that's it's more convenient to experiment tasks that adds info to the scrolling tree (e.g. bug 172917 and bug 176454).
Comment 4 Simon Fraser (smfr) 2018-12-04 11:43:47 PST
Comment on attachment 356517 [details]
Patch

Sure.
Comment 5 WebKit Commit Bot 2018-12-04 19:58:09 PST
Comment on attachment 356517 [details]
Patch

Clearing flags on attachment: 356517

Committed r238885: <https://trac.webkit.org/changeset/238885>
Comment 6 WebKit Commit Bot 2018-12-04 19:58:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-04 19:59:29 PST
<rdar://problem/46475451>