Bug 192358 - Always pass scrollingGeometry to update*ScrollingNode functions
Summary: Always pass scrollingGeometry to update*ScrollingNode functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 176454 172917
  Show dependency treegraph
 
Reported: 2018-12-04 03:03 PST by Frédéric Wang (:fredw)
Modified: 2018-12-04 19:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (12.81 KB, patch)
2018-12-04 03:04 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (12.81 KB, patch)
2018-12-04 03:27 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (13.73 KB, patch)
2018-12-04 11:07 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-12-04 03:03:41 PST
Always pass scrollingGeometry to update*ScrollingNode functions
Comment 1 Frédéric Wang (:fredw) 2018-12-04 03:04:25 PST
Created attachment 356478 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-12-04 03:27:56 PST
Created attachment 356481 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2018-12-04 11:07:33 PST
Created attachment 356517 [details]
Patch

I'm not sure how much this is aligned / conflicting with your work, but I wonder whether we could take this so that's it's more convenient to experiment tasks that adds info to the scrolling tree (e.g. bug 172917 and bug 176454).
Comment 4 Simon Fraser (smfr) 2018-12-04 11:43:47 PST
Comment on attachment 356517 [details]
Patch

Sure.
Comment 5 WebKit Commit Bot 2018-12-04 19:58:09 PST
Comment on attachment 356517 [details]
Patch

Clearing flags on attachment: 356517

Committed r238885: <https://trac.webkit.org/changeset/238885>
Comment 6 WebKit Commit Bot 2018-12-04 19:58:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-04 19:59:29 PST
<rdar://problem/46475451>