Summary: | Web Inspector: Audit: save the expanded state of test groups | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=192107 | ||||||||
Bug Depends on: | 190754 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2018-12-03 19:10:24 PST
Created attachment 356449 [details]
Patch
Comment on attachment 356449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review r=me > Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54 > + this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false); How about using a template string? `audit-tree-element-${this.representedObject.name}-expanded` Created attachment 356454 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 356454 [details]: inspector/model/auditTestCase.html bug 192350 (author: drousso@apple.com) http/tests/inspector/network/loadResource-insecure-resource.html bug 192351 (authors: drousso@apple.com and joepeck@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356454 [details]: inspector/unit-tests/event-listener.html bug 192050 (authors: bburg@apple.com and drousso@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 356454 [details] Patch Clearing flags on attachment: 356454 Committed r238843: <https://trac.webkit.org/changeset/238843> All reviewed patches have been landed. Closing bug. |