Bug 192346 – Web Inspector: Audit: save the expanded state of test groups

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

<https://webkit.org/b/192107> removed the auto-expanding of groups, but we should actually auto-expand if the user had previously done so (similar to resources).

[Radar WebKit Bug Importer]

<rdar://problem/46440703>

[Radar WebKit Bug Importer]

<rdar://problem/46440704>

[Devin Rousso]

Created attachment 356449 [details]
Patch

[Matt Baker]

Comment on attachment 356449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54
> +            this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false);

How about using a template string?

`audit-tree-element-${this.representedObject.name}-expanded`

[Devin Rousso]

Created attachment 356454 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 356454 [details]:

inspector/model/auditTestCase.html bug 192350 (author: [e-mail])
http/tests/inspector/network/loadResource-insecure-resource.html bug 192351 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 356454 [details]:

inspector/unit-tests/event-listener.html bug 192050 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 356454 [details]
Patch

Clearing flags on attachment: 356454

Committed r238843: <https://trac.webkit.org/changeset/238843>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.