Bug 192346 - Web Inspector: Audit: save the expanded state of test groups
Summary: Web Inspector: Audit: save the expanded state of test groups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency tree / graph
 
Reported: 2018-12-03 19:10 PST by Devin Rousso
Modified: 2018-12-03 22:01 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2018-12-03 19:37 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2018-12-03 20:57 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-12-03 19:10:24 PST 
<https://webkit.org/b/192107> removed the auto-expanding of groups, but we should actually auto-expand if the user had previously done so (similar to resources).
Comment 1 Radar WebKit Bug Importer 2018-12-03 19:10:49 PST 
<rdar://problem/46440703>
Comment 2 Radar WebKit Bug Importer 2018-12-03 19:10:51 PST 
<rdar://problem/46440704>
Comment 3 Devin Rousso 2018-12-03 19:37:16 PST 
Created attachment 356449 [details]
Patch
Comment 4 Matt Baker 2018-12-03 20:32:21 PST 
Comment on attachment 356449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356449&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:54
> +            this._expandedSetting = new WI.Setting("audit-tree-element-" + this.representedObject.name + "-expanded", false);

How about using a template string?

`audit-tree-element-${this.representedObject.name}-expanded`
Comment 5 Devin Rousso 2018-12-03 20:57:05 PST 
Created attachment 356454 [details]
Patch
Comment 6 WebKit Commit Bot 2018-12-03 21:46:12 PST 
The commit-queue encountered the following flaky tests while processing attachment 356454 [details]:

inspector/model/auditTestCase.html bug 192350 (author: drousso@apple.com)
http/tests/inspector/network/loadResource-insecure-resource.html bug 192351 (authors: drousso@apple.com and joepeck@webkit.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-12-03 21:46:21 PST 
The commit-queue encountered the following flaky tests while processing attachment 356454 [details]:

inspector/unit-tests/event-listener.html bug 192050 (authors: bburg@apple.com and drousso@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2018-12-03 22:01:24 PST 
Comment on attachment 356454 [details]
Patch

Clearing flags on attachment: 356454

Committed r238843: <https://trac.webkit.org/changeset/238843>
Comment 9 WebKit Commit Bot 2018-12-03 22:01:26 PST 
All reviewed patches have been landed.  Closing bug.