Bug 192341

Summary: Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P4 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2018-12-03 16:30:09 PST
Steps to Reproduce: 1. Select Audit tab 2. Close Inspector 3. Reopen Inspector => "No Filter Results" flashes before populating sidebar 1. Select Elements tab 2. Close Inspector 3. Reopen Inspector 4. Select Audit tab => "No Filter Results" flashes before populating sidebar
Attachments
Patch (4.25 KB, patch)
2018-12-03 19:07 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-03 16:31:04 PST
<rdar://problem/46436550>
Devin Rousso
Comment 2 2018-12-03 18:52:09 PST
This is somewhat expected, as the `WI.ObjectStore` is async and will probably take a moment to load its data. The "No Filter Results" is appearing because we do add a `WI.TreeElement` for the "Results" folder in `initialLayout`, which is default hidden, therefore triggering the placeholder. We can improve this by delaying it's creation (and append) till it's needed.
Devin Rousso
Comment 3 2018-12-03 19:07:41 PST
Created attachment 356446 [details] Patch
Matt Baker
Comment 4 2018-12-03 19:27:33 PST
Comment on attachment 356446 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-12-03 20:07:01 PST
Comment on attachment 356446 [details] Patch Clearing flags on attachment: 356446 Committed r238842: <https://trac.webkit.org/changeset/238842>
WebKit Commit Bot
Comment 6 2018-12-03 20:07:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.