| Summary: | CSS Properties and Values API should support animating registered custom properties without any references | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED --- | ||
| Severity: | Normal | CC: | achristensen, bfulgham, ews-watchlist, graouts, rniwa, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 192828 | ||
| Bug Blocks: | 192324 | ||
| Attachments: | |||
|
Description
Justin Michaud
2018-12-03 14:56:41 PST
Created attachment 356699 [details]
Patch
Attachment 356699 [details] did not pass style-queue:
ERROR: Source/WebCore/animation/KeyframeEffect.cpp:1202: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This patch is not complete yet. In particular, I would like to have the wpt tests for css variables imported first, to make sure nothing breaks. Right now, I have debug assertions everywhere just to aid in debugging. WebAnimations as well as declarative animations are not implemented yet. I am uploading this to get some preliminary feedback while I import the wpt tests and fix those bugs. Comment on attachment 356699 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356699&action=review > Source/WebCore/animation/AnimationTimeline.cpp:380 > +void AnimationTimeline::updateCustomPropertyCSSTransitionsForElement(Element& element, const RenderStyle& currentStyle, const RenderStyle& afterChangeStyle) Holy shit. > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1874 > + return (!aValue && !bValue) || (aValue && bValue && *aValue == *bValue); We have a thing for this: arePointingToEqualData() Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10287476 New failing tests: transitions/transitions-parsing.html legacy-animation-engine/transitions/transitions-parsing.html Created attachment 356703 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10287603 New failing tests: transitions/transitions-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html legacy-animation-engine/transitions/transitions-parsing.html Created attachment 356705 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10287568 New failing tests: transitions/transition-unknown-property-ignore.html legacy-animation-engine/transitions/transition-unknown-property-ignore.html transitions/transitions-parsing.html legacy-animation-engine/transitions/transitions-parsing.html Created attachment 356707 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10287817 New failing tests: transitions/transitions-parsing.html Created attachment 356711 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 356699 [details] Patch Attachment 356699 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10289191 New failing tests: transitions/transitions-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html legacy-animation-engine/transitions/transitions-parsing.html Created attachment 356720 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 357034 [details]
Patch
This is beautiful. Comment on attachment 357034 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Closing old bugs assigned to me Closing old bugs assigned to me Reopening. |