| Summary: | Support css-color-4 rgb functions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, ews-watchlist, koivisto, mmaxfield, rniwa, sam, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=193038 https://bugs.webkit.org/show_bug.cgi?id=193039 |
||
| Attachments: | |||
|
Description
Simon Fraser (smfr)
2018-12-03 13:57:02 PST
Created attachment 356403 [details]
Testcase
Created attachment 358081 [details]
Patch
Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10553336 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml Created attachment 358083 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10553347 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml Created attachment 358084 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10553566 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10553482 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml Created attachment 358086 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 358087 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10553487 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html Created attachment 358088 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 358098 [details]
Patch
Comment on attachment 358098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358098&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:511 > + auto consumeSeparator = [&] () -> bool { wouldn't "auto consumeSeparator = [&] {" just work? > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:533 > + auto consumeAlphaSeparator = [&] () { () can be dropped. |