Summary: | Update libwebrtc up to 0d007d7c4f | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | alex, commit-queue, eric.carlson, tsaunier, webkit-bug-importer, youennf | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
youenn fablet
2018-12-03 11:55:18 PST
Created attachment 356390 [details]
Patch
Created attachment 356436 [details]
Patch
Created attachment 356469 [details]
Patch
Created attachment 356793 [details]
GTK patch
This patch fixes compilation for GTK with the upgrade. I have also made some small test with webrtc in appr.tc and it works for chrome.
Comment on attachment 356793 [details] GTK patch View in context: https://bugs.webkit.org/attachment.cgi?id=356793&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:84 > const char* tag) { > - OnLogMessage(tag + (": " + msg)); > + OnLogMessage(tag + (": " + msg), severity); > +} > + > +void LogSink::OnLogMessage(const std::string& msg, > + LoggingSeverity /* severity */) { > + OnLogMessage(msg); > } This change adds again code removed previously in WebKit, not sure the reason we removed this originally. > Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/task_queue_libevent.cc:31 > +#if defined(WEBRTC_LINUX) > +#include <event2/event.h> > +#include <event2/event_compat.h> > +#include <event2/event_struct.h> > +#else > #include "base/third_party/libevent/event.h" > +#endif This is the usual requirement to use system libevent. Created attachment 356816 [details]
Patch with GTK changes
Comment on attachment 356816 [details]
Patch with GTK changes
rs=me once the bots are happy
Comment on attachment 356816 [details] Patch with GTK changes Clearing flags on attachment: 356816 Committed r238967: <https://trac.webkit.org/changeset/238967> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 356841 [details]
Patch
Comment on attachment 356841 [details] Patch Clearing flags on attachment: 356841 Committed r238971: <https://trac.webkit.org/changeset/238971> All reviewed patches have been landed. Closing bug. |