Bug 192282

Summary: Web Inspector: Add style editing debug mode
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, mattbaker, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 191567    
Attachments:
Description Flags
Patch
none
[Screenshot] Extra logging
none
[Image] Locked rule
none
Patch
none
Patch
none
Archive of layout-test-results from ews102 for mac-sierra none

Nikita Vasilyev
Reported 2018-12-01 17:32:13 PST
There are several bugs in style editing that are notoriously hard to debug. Add a debug setting to: - Enable extra logging. - Visualize locked style declarations.
Attachments
Patch (6.56 KB, patch)
2018-12-01 17:51 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Screenshot] Extra logging (141.27 KB, image/png)
2018-12-01 17:55 PST, Nikita Vasilyev 		no flags
Details
[Image] Locked rule (49.97 KB, image/png)
2018-12-01 17:56 PST, Nikita Vasilyev 		no flags
Details
Patch (6.56 KB, patch)
2018-12-01 17:57 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (6.65 KB, patch)
2018-12-04 14:11 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.68 MB, application/zip)
2018-12-04 15:01 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-01 17:33:29 PST
<rdar://problem/46399176>
Nikita Vasilyev
Comment 2 2018-12-01 17:51:21 PST
Created attachment 356327 [details] Patch
Nikita Vasilyev
Comment 3 2018-12-01 17:55:37 PST
Created attachment 356328 [details] [Screenshot] Extra logging Here, there's an issue with repeating semicolons when toggling properties.
Nikita Vasilyev
Comment 4 2018-12-01 17:56:17 PST
Created attachment 356329 [details] [Image] Locked rule
Nikita Vasilyev
Comment 5 2018-12-01 17:57:45 PST
Created attachment 356330 [details] Patch
Nikita Vasilyev
Comment 6 2018-12-04 14:11:09 PST
Created attachment 356531 [details] Patch Rebaseline.
EWS Watchlist
Comment 7 2018-12-04 15:01:28 PST
Comment on attachment 356531 [details] Patch Attachment 356531 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10269047 New failing tests: workers/bomb.html
EWS Watchlist
Comment 8 2018-12-04 15:01:30 PST
Created attachment 356542 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Nikita Vasilyev
Comment 9 2018-12-04 15:06:39 PST
Comment on attachment 356531 [details] Patch Unrelated test failure.
Matt Baker
Comment 10 2018-12-04 16:36:35 PST
Comment on attachment 356531 [details] Patch r=me
WebKit Commit Bot
Comment 11 2018-12-04 17:37:11 PST
Comment on attachment 356531 [details] Patch Clearing flags on attachment: 356531 Committed r238882: <https://trac.webkit.org/changeset/238882>
WebKit Commit Bot
Comment 12 2018-12-04 17:37:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.