Bug 192280

Summary: Add a runtime feature flag for LayoutFormattingContext.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, don.olmstead, ews-watchlist, keith_miller, koivisto, mark.lam, msaboff, saam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch none

alan
Reported 2018-12-01 14:09:23 PST
ssia
Attachments
Patch (11.48 KB, patch)
2018-12-01 14:15 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.18 KB, patch)
2018-12-01 14:37 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.88 KB, patch)
2018-12-01 18:47 PST, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (85.05 MB, application/zip)
2018-12-02 06:56 PST, EWS Watchlist 		no flags
Details
Patch (14.57 KB, patch)
2018-12-02 15:46 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-12-01 14:15:53 PST
Created attachment 356321 [details] Patch
alan
Comment 2 2018-12-01 14:37:52 PST
Created attachment 356322 [details] Patch
alan
Comment 3 2018-12-01 16:23:36 PST
Guess I never built LFC for release.
alan
Comment 4 2018-12-01 18:47:53 PST
Created attachment 356331 [details] Patch
Simon Fraser (smfr)
Comment 5 2018-12-01 19:23:28 PST
Comment on attachment 356331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356331&action=review > Source/WebKit/Shared/WebPreferences.yaml:1335 > + category: experimental internal for now, I think?
EWS Watchlist
Comment 6 2018-12-02 06:56:27 PST
Comment on attachment 356331 [details] Patch Attachment 356331 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10238989 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html
EWS Watchlist
Comment 7 2018-12-02 06:56:31 PST
Created attachment 356336 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
alan
Comment 8 2018-12-02 15:46:15 PST
Created attachment 356349 [details] Patch
WebKit Commit Bot
Comment 9 2018-12-02 19:24:50 PST
Comment on attachment 356349 [details] Patch Clearing flags on attachment: 356349 Committed r238791: <https://trac.webkit.org/changeset/238791>
WebKit Commit Bot
Comment 10 2018-12-02 19:24:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-12-02 19:25:56 PST
<rdar://problem/46407388>
Don Olmstead
Comment 12 2018-12-02 19:48:53 PST
Are there any details on LFC so other ports can determine whether or not they can or should enable it?
Don Olmstead
Comment 13 2018-12-02 19:48:53 PST Comment hidden (obsolete)
alan
Comment 14 2018-12-02 20:01:47 PST
(In reply to Don Olmstead from comment #13) > Are there any details on LFC so other ports can determine whether or not > they can or should enable it? This is internal yet (not even an experimental feature). Nowhere near ready to turn it on (and even when it is on, it just runs as a secondary layout and the tree it generates gets verified against the original render tree.) I am planning to write up a blog entry on this, but the short answer is no. No ports should enable it at this point.
Don Olmstead
Comment 15 2018-12-02 20:56:07 PST
(In reply to zalan from comment #14) > (In reply to Don Olmstead from comment #13) > > Are there any details on LFC so other ports can determine whether or not > > they can or should enable it? > This is internal yet (not even an experimental feature). Nowhere near ready > to turn it on (and even when it is on, it just runs as a secondary layout > and the tree it generates gets verified against the original render tree.) > I am planning to write up a blog entry on this, but the short answer is no. > No ports should enable it at this point. Thanks for the information! I saw this when I was looking at syncing the CMake and XCode feature set but was unsure what was happening. Looking forward to the blog entry
Note You need to log in before you can comment on or make changes to this bug.