Bug 192275

Summary:

Move URL tests from TestWebKitAPI to TestWTF

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, ews-watchlist, keith_miller, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Yusuke Suzuki

Reported 2018-11-30 22:12:05 PST

Move URL tests from TestWebKitAPI to TestWTF

Attachments
Patch (282.13 KB, patch) 2018-11-30 22:13 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (281.15 KB, patch) 2018-11-30 23:07 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-11-30 22:13:29 PST

Created attachment 356293 [details] Patch

EWS Watchlist

Comment 2 2018-11-30 22:15:32 PST

Attachment 356293 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 11 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 3 2018-11-30 23:07:04 PST

Created attachment 356296 [details] Patch

EWS Watchlist

Comment 4 2018-11-30 23:09:39 PST

Attachment 356296 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689: Should have a space between // and comment [whitespace/comments] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692: One space before end of line comments [whitespace/comments] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 10 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 5 2018-12-01 03:54:15 PST

Comment on attachment 356296 [details] Patch r=me

Yusuke Suzuki

Comment 6 2018-12-01 03:57:12 PST

Comment on attachment 356296 [details] Patch thanks!

WebKit Commit Bot

Comment 7 2018-12-01 04:23:33 PST

Comment on attachment 356296 [details] Patch Clearing flags on attachment: 356296 Committed r238779: <https://trac.webkit.org/changeset/238779>

WebKit Commit Bot

Comment 8 2018-12-01 04:23:35 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-12-01 04:24:43 PST

<rdar://problem/46395626>

Note You need to log in before you can comment on or make changes to this bug.