Bug 192263

Summary: Add generic implementations to FileSystemPOSIX.cpp
Product: WebKit Reporter: Christopher Reid <chris.reid>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, don.olmstead, Hironori.Fujii, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Christopher Reid 2018-11-30 15:57:19 PST 
Add generic POSIX implementations for stringFromFileSystemRepresentation, fileSystemRepresentation, moveFile, and getVolumeFreeSpace.
Comment 1 Christopher Reid 2018-11-30 16:32:18 PST 
Created attachment 356260 [details]
Patch
Comment 2 Christopher Reid 2018-11-30 17:04:47 PST 
I was wondering if any of these should replace cocoa's implementations.

stringFromFileSystemRepresentation is based off of CF's functionality on osx, Glib percent encodes most non-alphanumeric characters. There are however a couple of cases where CF's stringFromFileSystemRepresentation and String::fromUTF8 don't match with certain invalid utf-8 sequences.
Comment 3 Christopher Reid 2018-11-30 17:20:04 PST 
Created attachment 356267 [details]
Patch
Comment 4 Yusuke Suzuki 2018-12-01 04:32:06 PST 
Comment on attachment 356267 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-12-01 11:34:51 PST 
Comment on attachment 356267 [details]
Patch

Clearing flags on attachment: 356267

Committed r238782: <https://trac.webkit.org/changeset/238782>
Comment 6 WebKit Commit Bot 2018-12-01 11:34:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-01 11:35:37 PST 
<rdar://problem/46397333>