Bug 192260

Summary:

webkitpy: Support unicode in MeteredStream

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, rniwa, simon.fraser, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none

Jonathan Bedard

Reported 2018-11-30 15:16:50 PST

We should support unicode in the MeteredStream object since it's possible for test diffs to contain unicode.

Attachments
Patch (2.41 KB, patch) 2018-11-30 15:21 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.78 MB, application/zip) 2018-11-30 16:03 PST, EWS Watchlist	no flags	Details
Patch (2.83 KB, patch) 2018-12-03 13:21 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2018-11-30 15:21:34 PST

Created attachment 356246 [details] Patch

EWS Watchlist

Comment 2 2018-11-30 16:03:20 PST

Comment on attachment 356246 [details] Patch Attachment 356246 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10221118 New failing tests: workers/bomb.html

EWS Watchlist

Comment 3 2018-11-30 16:03:22 PST

Created attachment 356255 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Jonathan Bedard

Comment 4 2018-11-30 16:17:29 PST

workers/bomb.html is a flakey test.

Jonathan Bedard

Comment 5 2018-11-30 16:19:56 PST

*** Bug 188718 has been marked as a duplicate of this bug. ***

WebKit Commit Bot

Comment 6 2018-11-30 16:32:49 PST

Comment on attachment 356246 [details] Patch Clearing flags on attachment: 356246 Committed r238764: <https://trac.webkit.org/changeset/238764>

WebKit Commit Bot

Comment 7 2018-11-30 16:32:51 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-11-30 16:33:40 PST

<rdar://problem/46388376>

Jonathan Bedard

Comment 9 2018-12-01 13:09:10 PST

Reverted r238764 for reason: Breaks existing layout tests Committed r238784: <https://trac.webkit.org/changeset/238784>

Jonathan Bedard

Comment 10 2018-12-03 13:21:07 PST

Created attachment 356400 [details] Patch

WebKit Commit Bot

Comment 11 2018-12-04 11:00:34 PST

Comment on attachment 356400 [details] Patch Clearing flags on attachment: 356400 Committed r238862: <https://trac.webkit.org/changeset/238862>

WebKit Commit Bot

Comment 12 2018-12-04 11:00:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.