| Summary: | [WebGPU] Add scaffolding to parse WHLSL shaders | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | dino, ews-watchlist, fpizlo, glenn, jonlee, justin_fan, rmorisset, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2018-11-29 23:03:58 PST
Created attachment 356148 [details]
Patch
This doesn't build ANTLR from source; instead, it just checks in the precompiled runtime and parser generator tool. We can use them out-of-the-box, so I don't think it's necessary to waste everyone's time building them. I can't seem to get the "Review Patch" page to work with such a big patch, so I'll comment here. - do we have permission from legal to include this 3rd party tool? - would it be better to start with a result generated offline, before including the tool? (In reply to Dean Jackson from comment #3) > I can't seem to get the "Review Patch" page to work with such a big patch, > so I'll comment here. > > - do we have permission from legal to include this 3rd party tool? Do we need to? It's using the BSD license. > - would it be better to start with a result generated offline, before > including the tool? The tool is written in Java and the bots don't have Java installed so we're either going to have to install Java on the bots and all the WebKit dev's machines or do what you propose. (Or not use ANTLR) |