Bug 192189

Summary:

Web Inspector: Canvas: add singular localized string for "Record first %s frames"

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

190856

Bug Blocks:

175485

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2018-11-29 15:06:59 PST

When the auto-capture frame count is 1, "Record first 1 frames" is grammatically weird. It should be "Record first 1 frame".

Attachments
Patch (9.64 KB, patch) 2018-11-29 15:09 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (9.12 KB, patch) 2018-12-03 15:44 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-11-29 15:09:59 PST

Created attachment 356071 [details] Patch

Devin Rousso

Comment 2 2018-11-29 15:10:19 PST

<rdar://problem/46274398>

Joseph Pecoraro

Comment 3 2018-12-03 12:35:54 PST

Comment on attachment 356071 [details] Patch r=me

WebKit Commit Bot

Comment 4 2018-12-03 12:49:34 PST Comment hidden (obsolete)

Comment on attachment 356071 [details] Patch Rejecting attachment 356071 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 356071, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=356071&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192189&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 356071 from bug 192189. Fetching: https://bugs.webkit.org/attachment.cgi?id=356071 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 FAILED at 356. Hunk #2 succeeded at 700 (offset -1 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js.rej patching file Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js patching file Source/WebInspectorUI/UserInterface/Views/CheckboxNavigationItem.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10252149

Devin Rousso

Comment 5 2018-12-03 15:44:28 PST

Created attachment 356425 [details] Patch

WebKit Commit Bot

Comment 6 2018-12-03 16:15:29 PST

Comment on attachment 356425 [details] Patch Clearing flags on attachment: 356425 Committed r238829: <https://trac.webkit.org/changeset/238829>

WebKit Commit Bot

Comment 7 2018-12-03 16:15:30 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.