Bug 192182

Summary: [MediaStream] DeviceIdHashSaltStorage should use iframe and top level documents
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing. none

Eric Carlson
Reported 2018-11-29 14:41:56 PST
DeviceIdHashSaltStorage should use iframe and top level documents
Attachments
Patch (17.60 KB, patch)
2018-11-29 14:48 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (18.16 KB, patch)
2018-11-29 18:47 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-29 14:42:29 PST
<rdar://problem/46354914>
Eric Carlson
Comment 2 2018-11-29 14:48:44 PST
Created attachment 356061 [details] Patch
youenn fablet
Comment 3 2018-11-29 15:34:11 PST
Comment on attachment 356061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review > Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83 > void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler) We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins. > Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50 > + : documentOrigin(documentOrigin) WTFMove(documentOrigin) and WTFMove(parentOrigin)
Eric Carlson
Comment 4 2018-11-29 18:44:08 PST
Comment on attachment 356061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356061&action=review Thanks for the review! >> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:83 >> void DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins(const Vector<SecurityOriginData>& origins, CompletionHandler<void()>&& completionHandler) > > We probably need to update getDeviceIdHashSaltOrigins to also add the topOrigin to origins. Good point, fixed. >> Source/WebKit/UIProcess/DeviceIdHashSaltStorage.h:50 >> + : documentOrigin(documentOrigin) > > WTFMove(documentOrigin) and WTFMove(parentOrigin) Fixed.
Eric Carlson
Comment 5 2018-11-29 18:47:42 PST
Created attachment 356105 [details] Patch for landing.
WebKit Commit Bot
Comment 6 2018-11-29 19:15:11 PST
Comment on attachment 356105 [details] Patch for landing. Clearing flags on attachment: 356105 Committed r238724: <https://trac.webkit.org/changeset/238724>
WebKit Commit Bot
Comment 7 2018-11-29 19:15:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.