Bug 192175

Summary: Modernize version check for _suppressedAutoAddedHTTPHeaders
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
thorton: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
patch for landing
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Alexey Proskuryakov
Reported 2018-11-29 13:24:14 PST
More bikeshedding
Attachments
proposed patch (4.92 KB, patch)
2018-11-29 13:27 PST, Alexey Proskuryakov 		thorton: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.60 MB, application/zip)
2018-11-29 15:57 PST, EWS Watchlist 		no flags
Details
patch for landing (4.92 KB, patch)
2018-11-29 16:17 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.40 MB, application/zip)
2018-12-01 07:13 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-11-29 13:27:17 PST
Created attachment 356044 [details] proposed patch
Tim Horton
Comment 2 2018-11-29 13:28:56 PST
Comment on attachment 356044 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356044&action=review > Source/WTF/wtf/Platform.h:1412 > +/* FIXME: Does this work, and is this needed on other iOS family platforms? */ Nice.
EWS Watchlist
Comment 3 2018-11-29 15:57:16 PST
Comment on attachment 356044 [details] proposed patch Attachment 356044 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10203218 New failing tests: http/tests/blink/sendbeacon/beacon-same-origin.html
EWS Watchlist
Comment 4 2018-11-29 15:57:18 PST
Created attachment 356078 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Alexey Proskuryakov
Comment 5 2018-11-29 16:17:38 PST
Created attachment 356083 [details] patch for landing Messed up the check, indeed.
EWS Watchlist
Comment 6 2018-12-01 07:13:24 PST
Comment on attachment 356083 [details] patch for landing Attachment 356083 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10229421 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html
EWS Watchlist
Comment 7 2018-12-01 07:13:26 PST
Created attachment 356307 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Alexey Proskuryakov
Comment 8 2018-12-01 13:37:58 PST
Comment on attachment 356083 [details] patch for landing This test is super flaky.
WebKit Commit Bot
Comment 9 2018-12-01 14:04:51 PST
Comment on attachment 356083 [details] patch for landing Clearing flags on attachment: 356083 Committed r238785: <https://trac.webkit.org/changeset/238785>
WebKit Commit Bot
Comment 10 2018-12-01 14:04:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-12-01 14:05:37 PST
<rdar://problem/46398170>
Note You need to log in before you can comment on or make changes to this bug.