Bug 192175 - Modernize version check for _suppressedAutoAddedHTTPHeaders
Summary: Modernize version check for _suppressedAutoAddedHTTPHeaders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-29 13:24 PST by Alexey Proskuryakov
Modified: 2018-12-01 14:05 PST (History)
10 users (show)

See Also:

Attachments
proposed patch (4.92 KB, patch)
2018-11-29 13:27 PST, Alexey Proskuryakov 		thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.60 MB, application/zip)
2018-11-29 15:57 PST, EWS Watchlist 		no flags Details
patch for landing (4.92 KB, patch)
2018-11-29 16:17 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.40 MB, application/zip)
2018-12-01 07:13 PST, EWS Watchlist 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-11-29 13:24:14 PST 
More bikeshedding
Comment 1 Alexey Proskuryakov 2018-11-29 13:27:17 PST 
Created attachment 356044 [details]
proposed patch
Comment 2 Tim Horton 2018-11-29 13:28:56 PST 
Comment on attachment 356044 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356044&action=review

> Source/WTF/wtf/Platform.h:1412
> +/* FIXME: Does this work, and is this needed on other iOS family platforms? */

Nice.
Comment 3 EWS Watchlist 2018-11-29 15:57:16 PST 
Comment on attachment 356044 [details]
proposed patch

Attachment 356044 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10203218

New failing tests:
http/tests/blink/sendbeacon/beacon-same-origin.html
Comment 4 EWS Watchlist 2018-11-29 15:57:18 PST 
Created attachment 356078 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 Alexey Proskuryakov 2018-11-29 16:17:38 PST 
Created attachment 356083 [details]
patch for landing

Messed up the check, indeed.
Comment 6 EWS Watchlist 2018-12-01 07:13:24 PST 
Comment on attachment 356083 [details]
patch for landing

Attachment 356083 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10229421

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html
Comment 7 EWS Watchlist 2018-12-01 07:13:26 PST 
Created attachment 356307 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 Alexey Proskuryakov 2018-12-01 13:37:58 PST 
Comment on attachment 356083 [details]
patch for landing

This test is super flaky.
Comment 9 WebKit Commit Bot 2018-12-01 14:04:51 PST 
Comment on attachment 356083 [details]
patch for landing

Clearing flags on attachment: 356083

Committed r238785: <https://trac.webkit.org/changeset/238785>
Comment 10 WebKit Commit Bot 2018-12-01 14:04:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-12-01 14:05:37 PST 
<rdar://problem/46398170>