Bug 192158

Summary: webkitpy: Unify device creation
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2018-11-29 09:41:34 PST
The API for creating simulated devices and physical devices is identical. We should leverage this fact and create all devices in the DevicePort class.
Attachments
Patch (11.48 KB, patch)
2018-11-29 11:53 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.48 KB, patch)
2018-11-29 13:25 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-29 09:43:18 PST
<rdar://problem/46344757>
Jonathan Bedard
Comment 2 2018-11-29 11:53:47 PST
Created attachment 356031 [details] Patch
Lucas Forschler
Comment 3 2018-11-29 12:15:15 PST
Comment on attachment 356031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356031&action=review lgtm with typo fix > Tools/Scripts/webkitpy/port/device_port.py:130 > + raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes())) nit: typo enough
Simon Fraser (smfr)
Comment 4 2018-11-29 12:38:50 PST
Comment on attachment 356031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356031&action=review >> Tools/Scripts/webkitpy/port/device_port.py:130 >> + raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes())) > > nit: typo enough That should read "too few connected devices". Can this error fire for simulators?
Jonathan Bedard
Comment 5 2018-11-29 12:52:16 PST
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 356031 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356031&action=review > > >> Tools/Scripts/webkitpy/port/device_port.py:130 > >> + raise RuntimeError('Not enought connected devices for {} processes'.format(self.child_processes())) > > > > nit: typo enough > > That should read "too few connected devices". Can this error fire for > simulators? No, it cannot. Simulators will boot enough devices to match the number specified.
Jonathan Bedard
Comment 6 2018-11-29 13:25:19 PST
Created attachment 356042 [details] Patch for landing
WebKit Commit Bot
Comment 7 2018-11-29 13:58:38 PST
Comment on attachment 356042 [details] Patch for landing Clearing flags on attachment: 356042 Committed r238694: <https://trac.webkit.org/changeset/238694>
WebKit Commit Bot
Comment 8 2018-11-29 13:58:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.