Bug 192128

Summary: Make generic ScrollAnimator
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, fred.wang, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mcatanzaro: review+
Patch none

Don Olmstead
Reported 2018-11-28 18:18:27 PST
The contents of platform/gtk/ScrollAnimatorGtk doesn't contain anything thats GTK specific. Use that as a shared generic implementation.
Attachments
Patch (23.38 KB, patch)
2018-11-28 18:21 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (24.47 KB, patch)
2018-11-29 09:26 PST, Don Olmstead 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch (24.48 KB, patch)
2018-11-29 10:03 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-11-28 18:21:19 PST
Created attachment 355956 [details] Patch
Don Olmstead
Comment 2 2018-11-28 18:31:44 PST
I think EWS is having a problem because of unified sources....
Frédéric Wang (:fredw)
Comment 3 2018-11-29 05:38:49 PST
Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review > Source/WebCore/ChangeLog:15 > + compile at this time. ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-)
Frédéric Wang (:fredw)
Comment 4 2018-11-29 05:50:20 PST
Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review >> Source/WebCore/ChangeLog:15 >> + compile at this time. > > ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 > > Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-) OK, I stand corrected, what I need is ScrollAnimationSmooth!
Michael Catanzaro
Comment 5 2018-11-29 08:21:14 PST
Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review >>> Source/WebCore/ChangeLog:15 >>> + compile at this time. >> >> ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 >> >> Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-) > > OK, I stand corrected, what I need is ScrollAnimationSmooth! What is it you really need? (Not ScrollAnimatorSmooth.)
Frédéric Wang (:fredw)
Comment 6 2018-11-29 08:26:51 PST
(In reply to Michael Catanzaro from comment #5) > What is it you really need? (Not ScrollAnimatorSmooth.) I'm using ScrollAnimaTIONSmooth to implement programmatic smooth scrolling. Don is removing ScrollAnimaTORSmooth.
Don Olmstead
Comment 7 2018-11-29 09:26:29 PST
Created attachment 356013 [details] Patch Including potential build fix due to unified sources.
Don Olmstead
Comment 8 2018-11-29 09:40:34 PST
Comment on attachment 356013 [details] Patch Ok GTK is happy now. Ready for a review.
Michael Catanzaro
Comment 9 2018-11-29 09:56:05 PST
Comment on attachment 356013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356013&action=review > Source/WebCore/ChangeLog:8 > + No new tests. No change in behavior. This line is one space too far to the left!
Don Olmstead
Comment 10 2018-11-29 10:03:50 PST
Created attachment 356015 [details] Patch
WebKit Commit Bot
Comment 11 2018-11-29 10:36:38 PST
Comment on attachment 356015 [details] Patch Clearing flags on attachment: 356015 Committed r238675: <https://trac.webkit.org/changeset/238675>
WebKit Commit Bot
Comment 12 2018-11-29 10:36:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-11-29 10:37:21 PST
<rdar://problem/46346604>
Note You need to log in before you can comment on or make changes to this bug.