| Summary: | Make generic ScrollAnimator | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, fred.wang, mcatanzaro, webkit-bug-importer, zan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Don Olmstead
2018-11-28 18:18:27 PST
Created attachment 355956 [details]
Patch
I think EWS is having a problem because of unified sources.... Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review > Source/WebCore/ChangeLog:15 > + compile at this time. ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-) Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review >> Source/WebCore/ChangeLog:15 >> + compile at this time. > > ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 > > Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-) OK, I stand corrected, what I need is ScrollAnimationSmooth! Comment on attachment 355956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355956&action=review >>> Source/WebCore/ChangeLog:15 >>> + compile at this time. >> >> ScrollAnimatorSmooth seems to be still used on GTK: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/SourcesGTK.txt#L59 >> >> Also, I've been relying on this to implement CSS smooth scrolling on all ports bug 188043. So unless reviewers say my approach is incorrect, please keep the file for now :-) > > OK, I stand corrected, what I need is ScrollAnimationSmooth! What is it you really need? (Not ScrollAnimatorSmooth.) (In reply to Michael Catanzaro from comment #5) > What is it you really need? (Not ScrollAnimatorSmooth.) I'm using ScrollAnimaTIONSmooth to implement programmatic smooth scrolling. Don is removing ScrollAnimaTORSmooth. Created attachment 356013 [details]
Patch
Including potential build fix due to unified sources.
Comment on attachment 356013 [details]
Patch
Ok GTK is happy now. Ready for a review.
Comment on attachment 356013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356013&action=review > Source/WebCore/ChangeLog:8 > + No new tests. No change in behavior. This line is one space too far to the left! Created attachment 356015 [details]
Patch
Comment on attachment 356015 [details] Patch Clearing flags on attachment: 356015 Committed r238675: <https://trac.webkit.org/changeset/238675> All reviewed patches have been landed. Closing bug. |