Bug 192126

Summary:

[macOS] Add logging for some sandbox entries.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebCore Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2018-11-28 17:21:20 PST

Add logging for sandbox entries which are possibly not needed.

Attachments
Patch (6.02 KB, patch) 2018-11-28 17:31 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (1.21 MB, application/zip) 2018-11-28 18:17 PST, EWS Watchlist	no flags	Details
Patch (6.81 KB, patch) 2018-11-29 10:05 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (1.48 MB, application/zip) 2018-11-29 10:36 PST, EWS Watchlist	no flags	Details
Patch (6.90 KB, patch) 2018-11-29 11:52 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (6.84 KB, patch) 2018-11-29 12:40 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-11-28 17:22:03 PST

<rdar://problem/46327777>

Per Arne Vollan

Comment 2 2018-11-28 17:31:07 PST

Created attachment 355949 [details] Patch

EWS Watchlist

Comment 3 2018-11-28 18:17:00 PST

Comment on attachment 355949 [details] Patch Attachment 355949 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10190227 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2018-11-28 18:17:01 PST

Created attachment 355955 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Brent Fulgham

Comment 5 2018-11-28 19:34:35 PST

Comment on attachment 355949 [details] Patch Looks correct.

Brent Fulgham

Comment 6 2018-11-28 19:37:26 PST

Comment on attachment 355949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355949&action=review Switching to r- to fix the multiple crashes. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:608 > +(allow mach-lookup (with report) Is the “(with report)” unavailable on older OS? You might need to make this section conditional by OS.

Per Arne Vollan

Comment 7 2018-11-29 10:05:17 PST

Created attachment 356016 [details] Patch

EWS Watchlist

Comment 8 2018-11-29 10:36:16 PST

Comment on attachment 356016 [details] Patch Attachment 356016 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10199148 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 9 2018-11-29 10:36:17 PST

Created attachment 356022 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Per Arne Vollan

Comment 10 2018-11-29 11:52:45 PST

Created attachment 356030 [details] Patch

Per Arne Vollan

Comment 11 2018-11-29 12:40:59 PST

Created attachment 356037 [details] Patch

Brent Fulgham

Comment 12 2018-11-29 14:14:28 PST

Comment on attachment 356037 [details] Patch Great! R=me

Per Arne Vollan

Comment 13 2018-11-29 14:16:55 PST

(In reply to Brent Fulgham from comment #12) > Comment on attachment 356037 [details] > Patch > > Great! R=me Thanks for reviewing :)