| Summary: | [iOS] Page not defocused when Find-in-page becomes first responder | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, jer.noble, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | iOS 12 | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=190017 https://bugs.webkit.org/show_bug.cgi?id=133098 https://bugs.webkit.org/show_bug.cgi?id=192165 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Daniel Bates
2018-11-28 09:52:28 PST
Created attachment 355884 [details]
Patch and unit tests
Created attachment 355885 [details]
Patch and unit tests
Comment on attachment 355885 [details] Patch and unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=355885&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.h:2 > + * Copyright (C) 2018 Apple Inc. All rights reserved. Why the header? Most of our tests don't have corresponding headers. Comment on attachment 355885 [details] Patch and unit tests Attachment 355885 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10184286 Number of test failures exceeded the failure limit. Created attachment 355895 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Tim Horton from comment #4) > Comment on attachment 355885 [details] > Patch and unit tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355885&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.h:2 > > + * Copyright (C) 2018 Apple Inc. All rights reserved. > > Why the header? Most of our tests don't have corresponding headers. Will remove before landing. I didn't mean to include this file in the patch. Committed r238635: <https://trac.webkit.org/changeset/238635> Comment on attachment 355885 [details] Patch and unit tests View in context: https://bugs.webkit.org/attachment.cgi?id=355885&action=review > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:170 > + return [m_webView isFirstResponder]; As Wenson Hsieh pointed out to me, this code is wrong as [m_webView _isRetainingActiveFocusedState] is not being considered. (In reply to Daniel Bates from comment #9) > Comment on attachment 355885 [details] > Patch and unit tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355885&action=review > > > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:170 > > + return [m_webView isFirstResponder]; > > As Wenson Hsieh pointed out to me, this code is wrong as [m_webView > _isRetainingActiveFocusedState] is not being considered. This was fixed in the patch for bug #192165. |