Bug 192049

Summary: Move logCookieInformation bool from NetworkProcess to NetworkSession
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2018-11-27 16:06:34 PST
Move logCookieInformation bool from NetworkProcess to NetworkSession
Attachments
Patch (21.57 KB, patch)
2018-11-27 16:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (21.66 KB, patch)
2018-11-27 20:24 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (21.66 KB, patch)
2018-11-27 21:55 PST, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-11-27 16:07:07 PST
Created attachment 355805 [details] Patch
Chris Dumez
Comment 2 2018-11-27 16:41:25 PST
Comment on attachment 355805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355805&action=review > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:460 > + if (session->logCookieInformation()) This is a bad name, makes it sound like it is actually logging stuff. Should be named shouldLogCookieInformation() like it was. > Source/WebKit/NetworkProcess/NetworkSession.h:50 > + virtual bool logCookieInformation() const { return false; } Bad naming. > Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:58 > + bool logCookieInformation { false }; Bad naming. > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:86 > + bool m_logCookieInformation { false }; Bad naming.
Alex Christensen
Comment 3 2018-11-27 20:24:10 PST
Created attachment 355844 [details] Patch
Alex Christensen
Comment 4 2018-11-27 21:55:17 PST
Created attachment 355847 [details] Patch
Alex Christensen
Comment 5 2018-11-28 13:09:22 PST
http://trac.webkit.org/r238630
Radar WebKit Bug Importer
Comment 6 2018-11-28 13:10:40 PST
<rdar://problem/46319225>
Note You need to log in before you can comment on or make changes to this bug.