Bug 192041

Summary: Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, dbates, dino, ews-watchlist, japhet, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Alexey Proskuryakov
Reported 2018-11-27 14:57:44 PST
More bikeshedding. But also some big FIXMEs here.
Attachments
proposed patch (7.70 KB, patch)
2018-11-27 14:59 PST, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-11-27 14:59:59 PST
Created attachment 355788 [details] proposed patch
EWS Watchlist
Comment 2 2018-11-27 15:01:59 PST
Attachment 355788 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/mac/ResourceHandleMac.mm:116: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2018-11-29 12:41:13 PST
Comment on attachment 355788 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355788&action=review > Source/WTF/wtf/Platform.h:1386 > +/* The override isn't needed on iOS family, as the default behavior is to no sniff. */ s/no/not/, I think?
Alexey Proskuryakov
Comment 4 2018-11-29 12:53:07 PST
Committed http://trac.webkit.org/r238685
Radar WebKit Bug Importer
Comment 5 2018-11-29 12:54:37 PST
<rdar://problem/46351213>
Note You need to log in before you can comment on or make changes to this bug.