Bug 192032

Summary:

Make generic EventHandler methods

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, commit-queue, darin, don.olmstead, ews-watchlist, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Move EventHandler methods from EventHandlerGlib	none
Move EventHandler methods from EventHandlerGlib	ews-watchlist: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Move EventHandler methods from EventHandlerGlib	none

Stephan Szabo

Reported 2018-11-27 13:34:20 PST

Currently there are a number of methods in EventHandlerGlib that can be used for other non-apple platforms. Of those, there are two methods which seem like generic implementations, but currently have different behavior for Windows, so those are overridden there.

Attachments
Move EventHandler methods from EventHandlerGlib (10.81 KB, patch) 2018-11-27 14:14 PST, Stephan Szabo	no flags	Details Formatted Diff Diff
Move EventHandler methods from EventHandlerGlib (10.98 KB, patch) 2018-11-27 16:13 PST, Stephan Szabo	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.49 MB, application/zip) 2018-11-27 19:38 PST, EWS Watchlist	no flags	Details
Move EventHandler methods from EventHandlerGlib (10.98 KB, patch) 2018-11-28 07:26 PST, Stephan Szabo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Stephan Szabo

Comment 1 2018-11-27 14:14:54 PST

Created attachment 355778 [details] Move EventHandler methods from EventHandlerGlib

Don Olmstead

Comment 2 2018-11-27 16:00:30 PST

Comment on attachment 355778 [details] Move EventHandler methods from EventHandlerGlib View in context: https://bugs.webkit.org/attachment.cgi?id=355778&action=review Overall LGTM. What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code? Should that just be a !PLATFORM(GTK)in EventHandler.cpp since WPE doesn't actually implement. Then it would be EventHandlerGtk.cpp. > Source/WebCore/page/EventHandler.cpp:4279 > +#if !PLATFORM(MAC) && !PLATFORM(IOS) This could be simplified to !PLATFORM(COCOA) > Source/WebCore/page/EventHandler.cpp:4338 > +#if !PLATFORM(MAC) && !PLATFORM(IOS) && !PLATFORM(WIN) Same

Stephan Szabo

Comment 3 2018-11-27 16:09:51 PST

> What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code? I'm not sure. It seems like the implementation in EventHandler.cpp was there when EventHandlerGtk and EventHandlerWPE merged into EventHandlerGlib, so I left it as is.

Stephan Szabo

Comment 4 2018-11-27 16:13:39 PST

Created attachment 355806 [details] Move EventHandler methods from EventHandlerGlib

EWS Watchlist

Comment 5 2018-11-27 19:38:30 PST

Comment on attachment 355806 [details] Move EventHandler methods from EventHandlerGlib Attachment 355806 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10176073 New failing tests: media/no-fullscreen-when-hidden.html

EWS Watchlist

Comment 6 2018-11-27 19:38:32 PST

Created attachment 355841 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Stephan Szabo

Comment 7 2018-11-28 07:26:31 PST

Created attachment 355871 [details] Move EventHandler methods from EventHandlerGlib

WebKit Commit Bot

Comment 8 2018-11-28 10:24:13 PST

Comment on attachment 355871 [details] Move EventHandler methods from EventHandlerGlib Clearing flags on attachment: 355871 Committed r238622: <https://trac.webkit.org/changeset/238622>

WebKit Commit Bot

Comment 9 2018-11-28 10:24:14 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2018-11-28 10:25:46 PST

<rdar://problem/46313705>

Note You need to log in before you can comment on or make changes to this bug.