Summary: | Make generic EventHandler methods | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, clopez, commit-queue, darin, don.olmstead, ews-watchlist, mcatanzaro, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Stephan Szabo
2018-11-27 13:34:20 PST
Created attachment 355778 [details]
Move EventHandler methods from EventHandlerGlib
Comment on attachment 355778 [details] Move EventHandler methods from EventHandlerGlib View in context: https://bugs.webkit.org/attachment.cgi?id=355778&action=review Overall LGTM. What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code? Should that just be a !PLATFORM(GTK)in EventHandler.cpp since WPE doesn't actually implement. Then it would be EventHandlerGtk.cpp. > Source/WebCore/page/EventHandler.cpp:4279 > +#if !PLATFORM(MAC) && !PLATFORM(IOS) This could be simplified to !PLATFORM(COCOA) > Source/WebCore/page/EventHandler.cpp:4338 > +#if !PLATFORM(MAC) && !PLATFORM(IOS) && !PLATFORM(WIN) Same > What's up with EventHandler::shouldSwapScrollDirection though in the EventHandlerGlib.cpp code?
I'm not sure. It seems like the implementation in EventHandler.cpp was there when EventHandlerGtk and EventHandlerWPE merged into EventHandlerGlib, so I left it as is.
Created attachment 355806 [details]
Move EventHandler methods from EventHandlerGlib
Comment on attachment 355806 [details] Move EventHandler methods from EventHandlerGlib Attachment 355806 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10176073 New failing tests: media/no-fullscreen-when-hidden.html Created attachment 355841 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 355871 [details]
Move EventHandler methods from EventHandlerGlib
Comment on attachment 355871 [details] Move EventHandler methods from EventHandlerGlib Clearing flags on attachment: 355871 Committed r238622: <https://trac.webkit.org/changeset/238622> All reviewed patches have been landed. Closing bug. |