Bug 192029

Summary: Update generate-unified-source-bundles.rb to generate .xcfilelist files
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, keith_miller, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2018-11-27 13:09:01 PST
Update generate-unified-source-bundles.rb to generate output for .xcfilelist files. These files are used to indicate the sets of input and output files to Run Script build phases in Xcode. By invoking generate-unified-source-bundles.rb with -generate-xcfilelists, the script generates these .xcfilelist files. These .xcfilelist files can then be used to specify the inputs and outputs of the Generate Unified Sources build phases.
Attachments
Patch (8.08 KB, patch)
2018-11-27 13:11 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2018-11-27 15:26 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-27 13:09:26 PST
<rdar://problem/46285918>
Keith Rollin
Comment 2 2018-11-27 13:11:53 PST
Created attachment 355770 [details] Patch
Keith Rollin
Comment 3 2018-11-27 14:39:06 PST
Looks like my change to to_s is causing problems: /home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:174:in `to_s': Unreachable (RuntimeError) from /home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:353:in `join' from /home/buildbot/ews/WebKit/WebKitBuild/Release/DerivedSources/ForwardingHeaders/wtf/Scripts/generate-unified-source-bundles.rb:353:in `<main>'
Keith Rollin
Comment 4 2018-11-27 15:26:13 PST
Created attachment 355796 [details] Patch
WebKit Commit Bot
Comment 5 2018-11-28 14:07:52 PST
Comment on attachment 355796 [details] Patch Clearing flags on attachment: 355796 Committed r238638: <https://trac.webkit.org/changeset/238638>
WebKit Commit Bot
Comment 6 2018-11-28 14:07:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.