Bug 192027

Summary: [WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, ews-watchlist, pnormand, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews102 for mac-sierra none

Thibault Saunier
Reported 2018-11-27 12:30:13 PST
[WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource
Attachments
Patch (6.00 KB, patch)
2018-11-27 12:30 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (6.02 KB, patch)
2018-11-27 12:36 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.49 MB, application/zip)
2018-11-27 14:54 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-11-27 12:30:47 PST
Created attachment 355762 [details] Patch
EWS Watchlist
Comment 2 2018-11-27 12:33:48 PST
Attachment 355762 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thibault Saunier
Comment 3 2018-11-27 12:36:04 PST
Created attachment 355764 [details] Patch
EWS Watchlist
Comment 4 2018-11-27 14:54:09 PST
Comment on attachment 355764 [details] Patch Attachment 355764 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10172132 New failing tests: http/wpt/css/css-animations/start-animation-001.html
EWS Watchlist
Comment 5 2018-11-27 14:54:10 PST
Created attachment 355787 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
WebKit Commit Bot
Comment 6 2018-11-28 04:41:58 PST
Comment on attachment 355764 [details] Patch Clearing flags on attachment: 355764 Committed r238606: <https://trac.webkit.org/changeset/238606>
WebKit Commit Bot
Comment 7 2018-11-28 04:41:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-28 04:43:02 PST
<rdar://problem/46306727>
Note You need to log in before you can comment on or make changes to this bug.