| Summary: | [WebRTC][GStreamer] Use a GUniquePtr to hold the GstAudioConverter in our OutgoingAudioSource | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||||
| Component: | New Bugs | Assignee: | Thibault Saunier <tsaunier> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | calvaris, commit-queue, ews-watchlist, pnormand, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Thibault Saunier
2018-11-27 12:30:13 PST
Created attachment 355762 [details]
Patch
Attachment 355762 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 355764 [details]
Patch
Comment on attachment 355764 [details] Patch Attachment 355764 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10172132 New failing tests: http/wpt/css/css-animations/start-animation-001.html Created attachment 355787 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 355764 [details] Patch Clearing flags on attachment: 355764 Committed r238606: <https://trac.webkit.org/changeset/238606> All reviewed patches have been landed. Closing bug. |