Bug 192019

Summary: REGRESSION: stress/materialized-regexp-has-correct-last-index-set-by-match.js timing out on 32-bit JSC bot
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, mark.lam, tsavell, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Ryan Haddad
Reported 2018-11-27 11:11:44 PST
stress/materialized-regexp-has-correct-last-index-set-by-match.js is timing out on the 32-bit JSC bot https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2956
Attachments
proposed patch. (1.19 KB, patch)
2018-12-17 23:18 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-11-27 11:12:38 PST
The first test run exhibiting this issue contained the following RegExp changes: RegExp operations should not take fast patch if lastIndex is not numeric. https://trac.webkit.org/changeset/238267 RegExpObject's collectMatches should not be using JSArray::push to fill in its match results. https://trac.webkit.org/changeset/238270
Radar WebKit Bug Importer
Comment 2 2018-12-06 09:25:41 PST
<rdar://problem/46525456>
Mark Lam
Comment 3 2018-12-17 23:18:55 PST
Created attachment 357541 [details] proposed patch.
Yusuke Suzuki
Comment 4 2018-12-17 23:20:27 PST
Comment on attachment 357541 [details] proposed patch. r=me
WebKit Commit Bot
Comment 5 2018-12-17 23:59:07 PST
Comment on attachment 357541 [details] proposed patch. Clearing flags on attachment: 357541 Committed r239327: <https://trac.webkit.org/changeset/239327>
WebKit Commit Bot
Comment 6 2018-12-17 23:59:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.