Bug 191994

Summary:

[ews-app] Add BeautifulSoup

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	lforschler: review+

Description Aakash Jain 2018-11-26 19:41:28 PST

We need BeautifulSoup to parse the review page http://bugs.webkit.org/request.cgi?action=queue&type=review&group=type  (in https://bugs.webkit.org/show_bug.cgi?id=191942).

We should add BeautifulSoup. It can be copied from Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py

Comment 1 Aakash Jain 2018-11-26 19:52:14 PST

Created attachment 355705 [details]
Proposed patch

Comment 2 EWS Watchlist 2018-11-26 19:54:31 PST

Attachment 355705 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:93:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:95:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:107:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:113:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:194:  multiple spaces after operator  [pep8/E222] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:214:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:231:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:276:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:289:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:303:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:322:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:419:  multiple spaces before operator  [pep8/E221] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:424:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:448:  deprecated form of raising exception  [pep8/W602] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:459:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:464:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:471:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:475:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:479:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:486:  missing whitespace after ','  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:490:  whitespace after '{'  [pep8/E201] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:596:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:640:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:651:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:655:  deprecated form of raising exception  [pep8/W602] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:752:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:802:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:813:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:930:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:932:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:934:  missing whitespace after ','  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:970:  deprecated form of raising exception  [pep8/W602] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:992:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:995:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1006:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1015:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1023:  missing whitespace after ','  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1025:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1036:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1063:  whitespace before ']'  [pep8/E202] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1078:  whitespace after '{'  [pep8/E201] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1155:  whitespace before ':'  [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1155:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1166:  whitespace before '('  [pep8/E211] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1208:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1259:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1270:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1272:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1301:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1304:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1314:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1451:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1452:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1453:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1454:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1455:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1455:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1456:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1456:  missing whitespace around operator  [pep8/E225] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1457:  indentation is not a multiple of four  [pep8/E111] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1467:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1516:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1522:  whitespace before ','  [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1527:  whitespace before ':'  [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1541:  whitespace after '{'  [pep8/E201] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1549:  whitespace before ':'  [pep8/E203] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1591:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1601:  expected 1 blank line, found 0  [pep8/E301] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1620:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1623:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1659:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1672:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1699:  .has_key() is deprecated, use 'in'  [pep8/W601] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1711:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1713:  expected 2 blank lines, found 0  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1715:  expected 2 blank lines, found 0  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1717:  expected 2 blank lines, found 0  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1719:  expected 2 blank lines, found 0  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1753:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1763:  whitespace after '{'  [pep8/E201] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1781:  multiple statements on one line (colon)  [pep8/E701] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1785:  multiple statements on one line (colon)  [pep8/E701] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1795:  multiple statements on one line (colon)  [pep8/E701] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1798:  multiple statements on one line (colon)  [pep8/E701] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1823:  whitespace before '('  [pep8/E211] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1932:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1939:  multiple statements on one line (colon)  [pep8/E701] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1949:  expected 1 blank line, found 0  [pep8/E301] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1952:  missing whitespace after ','  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1974:  whitespace after '{'  [pep8/E201] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:2005:  missing whitespace after ','  [pep8/E231] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:148:  [PageElement.replaceWithChildren] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:185:  [PageElement._lastRecursiveChild] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:186:  [PageElement._lastRecursiveChild] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:194:  [PageElement.insert] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:199:  [PageElement.insert] Instance of 'PageElement' has no 'index' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:214:  [PageElement.insert] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:223:  [PageElement.insert] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:238:  [PageElement.insert] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:246:  [PageElement.insert] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:250:  [PageElement.append] Instance of 'PageElement' has no 'contents' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:483:  [Tag._invert] Method should have "self" as first argument  [pylint/E0213] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:995:  [SoupStrainer._matches] Instance of 'unicode' has no 'has_key' member (but some types could not be inferred)  [pylint/E1103] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1140:  [BeautifulStoneSoup.__init__] Instance of 'str' has no 'read' member (but some types could not be inferred)  [pylint/E1103] [5]
ERROR: Tools/BuildSlaveSupport/ews-app/ews/thirdparty/BeautifulSoup.py:1199:  [BeautifulStoneSoup.__getattr__] Class 'SGMLParser' has no '__getattr__' member  [pylint/E1101] [5]
Total errors found: 105 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Aakash Jain 2018-11-28 13:51:06 PST

Committed r238634: <http://trac.webkit.org/changeset/238634>

Comment 4 Radar WebKit Bug Importer 2018-11-28 13:52:23 PST

<rdar://problem/46320561>