Bug 191987

Summary: Modernize the check for async _saveCookies existence
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, ews-watchlist, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
With Tim's sugestion none

Alexey Proskuryakov
Reported 2018-11-26 15:55:48 PST
Try removing an explicit OS version check.
Attachments
proposed patch (4.90 KB, patch)
2018-11-26 16:02 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
With Tim's sugestion (4.91 KB, patch)
2018-11-27 09:23 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-11-26 16:02:22 PST
Created attachment 355688 [details] proposed patch
Alexey Proskuryakov
Comment 2 2018-11-26 16:04:37 PST
Bikeshedding is welcome, I want to polish the naming.
Tim Horton
Comment 3 2018-11-26 16:05:11 PST
Comment on attachment 355688 [details] proposed patch The other obvious option is "FOUNDATION_WITH_..."
Alexey Proskuryakov
Comment 4 2018-11-27 09:23:36 PST
Created attachment 355740 [details] With Tim's sugestion Yes, I think that's a bit better.
WebKit Commit Bot
Comment 5 2018-11-27 11:19:25 PST
Comment on attachment 355740 [details] With Tim's sugestion Rejecting attachment 355740 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 355740, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=355740&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191987&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit 1966f6a0b8c..71aad01c2a9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7 last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091. Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit 1966f6a0b8c..71aad01c2a9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7 last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091. Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit 1966f6a0b8c..71aad01c2a9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 238557 = d403ecb81ae0329ee6784d062687e12049f038b7 last_rev is higher!: 238557 >= 238542 at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 2091. Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2963. Full output: https://webkit-queues.webkit.org/results/10169410
WebKit Commit Bot
Comment 6 2018-11-27 12:40:50 PST
Comment on attachment 355740 [details] With Tim's sugestion Clearing flags on attachment: 355740 Committed r238567: <https://trac.webkit.org/changeset/238567>
WebKit Commit Bot
Comment 7 2018-11-27 12:40:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-27 12:42:07 PST
<rdar://problem/46285110>
Note You need to log in before you can comment on or make changes to this bug.