Summary: | Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2018-11-26 14:56:46 PST
Created attachment 355680 [details]
Patch
Comment on attachment 355680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355680&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:474 > -@property (nonatomic, readonly) UIView *_safeBrowsingWarningForTesting WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > +@property (nonatomic, readonly) UIView *_safeBrowsingWarning WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); If you're going to 'use it for more than just testing', you need to move it out of the WKTesting category too. |