Bug 191975

Summary: Intersection Observer: rootMargin: '' gives weird results
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebCore Misc.Assignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase
none
Patch none

Simon Fraser (smfr)
Reported 2018-11-26 12:13:24 PST
Created attachment 355665 [details] Testcase Setting rootMargin to an empty string causes weird behavior (intersection observations in the wrong place). Doesn't happen in Chrome.
Attachments
Testcase (2.22 KB, text/html)
2018-11-26 12:13 PST, Simon Fraser (smfr) 		no flags
Details
Patch (4.39 KB, patch)
2018-11-27 10:22 PST, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-11-27 10:22:11 PST
Created attachment 355746 [details] Patch
Ali Juma
Comment 2 2018-11-27 11:08:09 PST
Upstream PR for the new WPT is https://github.com/web-platform-tests/wpt/pull/14266
Simon Fraser (smfr)
Comment 3 2018-11-27 13:53:24 PST
Comment on attachment 355746 [details] Patch Nice.
WebKit Commit Bot
Comment 4 2018-11-28 07:06:26 PST
Comment on attachment 355746 [details] Patch Clearing flags on attachment: 355746 Committed r238610: <https://trac.webkit.org/changeset/238610>
WebKit Commit Bot
Comment 5 2018-11-28 07:06:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-28 07:07:35 PST
<rdar://problem/46309082>
Note You need to log in before you can comment on or make changes to this bug.