Bug 191972

Summary: Move testRunner.toggleCapsLock() to uiController
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, pvollan, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 191815    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-11-26 10:49:14 PST
Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript object for UI test functions. Having this functionality be on uiController makes it an asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know when the Caps Lock key event is dispatched. It also facilitates its use directly as part of scripts with other uiController functions invocations that are passed in a single invocation of testRunner.runUIScript().
Attachments
Patch (17.06 KB, patch)
2018-11-26 10:50 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-11-26 10:50:29 PST
Created attachment 355654 [details] Patch
Daniel Bates
Comment 2 2018-11-26 12:41:22 PST
Comment on attachment 355654 [details] Patch Clearing flags on attachment: 355654 Committed r238512: <https://trac.webkit.org/changeset/238512>
Daniel Bates
Comment 3 2018-11-26 12:41:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-11-26 12:42:33 PST
<rdar://problem/46253251>
Note You need to log in before you can comment on or make changes to this bug.