Bug 191967

Summary: REGRESSION (r237738): Command Down Arrow doesn't scroll to the end of a page anymore
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Bug Depends on: 190487    
Bug Blocks: 191815    
Attachments:
Description Flags
Patch and layout tests none

Description Daniel Bates 2018-11-26 09:46:33 PST 
Steps to reproduce:
1. Visit <https://www.apple.com>.
2. Press Command + Down Arrow.

Then nothing happens. But the page should be scrolled to the bottom.
Comment 1 Daniel Bates 2018-11-26 09:47:59 PST 
Following r237738 the value of the enumerations used to identify modifier keys (e.g. Shift) changed to match the values of the corresponding enumerations in GraphicsServices, which are the enumerations UIKit uses to computes the modifier flags bitmask when instantiating a WebEvent to pass to WebKit. Before r237738 WebKit was using enumerations whose values matched the values of the corresponding UIKit public API UIKeyModifier* enumerations. For non-content editable elements, WebKit intercepts UIKit events in -_handleKeyUIEvent, synthesizes and dispatches its own WebEvent. However it was creating WebEvents with a modifier flags bitmask built from the UIKeyModifier* enumerations, -_modifierFlags, as opposed to a bitmask from the GraphicsServices enumerations, -_gsModifierFlags.
Comment 2 Daniel Bates 2018-11-26 09:49:39 PST 
Created attachment 355645 [details]
Patch and layout tests
Comment 3 Daniel Bates 2018-11-26 14:57:48 PST 
Comment on attachment 355645 [details]
Patch and layout tests

Clearing flags on attachment: 355645

Committed r238526: <https://trac.webkit.org/changeset/238526>
Comment 4 Daniel Bates 2018-11-26 14:57:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2018-11-26 14:58:03 PST 
<rdar://problem/45976390>