Bug 191956

Summary: InPlaceAbstractState::endBasicBlock rule for SetLocal should filter the value based on the flush format
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Description Saam Barati 2018-11-25 18:51:27 PST 
Otherwise, we may end up saying that the value the GetLocal loads isn't a subtype of its FlushFormat.
Comment 1 Saam Barati 2018-11-25 18:51:53 PST 
<rdar://problem/45665806>
Comment 2 Saam Barati 2018-11-25 19:11:23 PST 
Created attachment 355613 [details]
patch
Comment 3 Yusuke Suzuki 2018-11-25 23:06:45 PST 
Comment on attachment 355613 [details]
patch

r=me
Comment 4 EWS Watchlist 2018-11-26 09:11:03 PST 
Comment on attachment 355613 [details]
patch

Attachment 355613 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10154747

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 5 EWS Watchlist 2018-11-26 09:11:05 PST 
Created attachment 355643 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 WebKit Commit Bot 2018-11-26 12:29:43 PST 
Comment on attachment 355613 [details]
patch

Clearing flags on attachment: 355613

Committed r238511: <https://trac.webkit.org/changeset/238511>
Comment 7 WebKit Commit Bot 2018-11-26 12:29:45 PST 
All reviewed patches have been landed.  Closing bug.