Bug 191951

Summary: RemoteLayerTreeNode construction cleanups
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
thorton: review+
for landing none

Antti Koivisto
Reported 2018-11-25 00:58:44 PST
Make it nicer
Attachments
patch (19.15 KB, patch)
2018-11-25 01:16 PST, Antti Koivisto 		thorton: review+
DetailsFormatted DiffDiff
for landing (19.29 KB, patch)
2018-11-25 03:26 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-11-25 01:16:44 PST
Created attachment 355586 [details] patch
Tim Horton
Comment 2 2018-11-25 01:53:27 PST
Comment on attachment 355586 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=355586&action=review > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:64 > + [layer() setValue:[NSNumber numberWithUnsignedLongLong:layerID] forKey:WKLayerIDPropertyKey]; Can probably just @(layerID) instead of [NSNumber numberWithUnsignedLongLong:layerID]
Antti Koivisto
Comment 3 2018-11-25 03:26:01 PST
Created attachment 355591 [details] for landing
WebKit Commit Bot
Comment 4 2018-11-25 04:19:12 PST
Comment on attachment 355591 [details] for landing Clearing flags on attachment: 355591 Committed r238476: <https://trac.webkit.org/changeset/238476>
WebKit Commit Bot
Comment 5 2018-11-25 04:19:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-25 04:20:32 PST
<rdar://problem/46230958>
Note You need to log in before you can comment on or make changes to this bug.