Bug 191936

Summary:

Add raw pointer overloads to ListHashSet via SmartPtr specialized functions

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, jlewis3, ryanhaddad, tsavell, webkit-bug-importer, ysuzuki, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Sam Weinig

Reported 2018-11-23 18:33:25 PST

Add raw pointer overloads to ListHashSet via SmartPtr specialized functions

Attachments
Patch (9.45 KB, patch) 2018-11-23 18:44 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (9.46 KB, patch) 2018-11-23 19:34 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2018-11-23 18:44:44 PST Comment hidden (obsolete)

Created attachment 355545 [details] Patch

EWS Watchlist

Comment 2 2018-11-23 18:47:23 PST Comment hidden (obsolete)

Attachment 355545 [details] did not pass style-queue: ERROR: Source/WTF/wtf/ListHashSet.h:639: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:649: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:659: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:666: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:673: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:680: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 6 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2018-11-23 19:34:35 PST

Created attachment 355551 [details] Patch

EWS Watchlist

Comment 4 2018-11-23 19:37:38 PST

Attachment 355551 [details] did not pass style-queue: ERROR: Source/WTF/wtf/ListHashSet.h:639: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:649: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:659: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:666: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:673: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/ListHashSet.h:680: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 6 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

alan

Comment 5 2018-11-23 21:31:43 PST

Comment on attachment 355551 [details] Patch omg, thank you. I've been wanting to do this for months.

Sam Weinig

Comment 6 2018-11-23 21:44:15 PST

(In reply to zalan from comment #5) > Comment on attachment 355551 [details] > Patch > > omg, thank you. I've been wanting to do this for months. Yeah, I saw the FIXME and decided to do it. I have a follow up which fixes the InlineItem list.

WebKit Commit Bot

Comment 7 2018-11-23 22:08:38 PST

Comment on attachment 355551 [details] Patch Clearing flags on attachment: 355551 Committed r238467: <https://trac.webkit.org/changeset/238467>

WebKit Commit Bot

Comment 8 2018-11-23 22:08:40 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2018-11-23 22:09:27 PST

<rdar://problem/46226142>

Yusuke Suzuki

Comment 10 2018-11-23 22:13:13 PST

Nice!

Ryan Haddad

Comment 11 2018-11-25 21:45:28 PST

One of the API tests added with this change is failing on iOS: TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp:453 Expected equality of these values: ptrWith2 Which is: 0x7faee4f03c90 firstWith4.get() Which is: 0x7faee4f03ca0 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/run-api-tests/logs/stdio

Ryan Haddad

Comment 12 2018-11-25 21:47:15 PST

(In reply to Ryan Haddad from comment #11) > One of the API tests added with this change is failing on iOS: > > TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > WTF/ListHashSet.cpp:453 > Expected equality of these values: > ptrWith2 > Which is: 0x7faee4f03c90 > firstWith4.get() > Which is: 0x7faee4f03ca0 > > https://build.webkit.org/builders/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/ > run-api-tests/logs/stdio Oh, I think this was fixed in https://trac.webkit.org/changeset/238486/webkit

alan

Comment 13 2018-11-25 21:47:50 PST

(In reply to Ryan Haddad from comment #12) > (In reply to Ryan Haddad from comment #11) > > One of the API tests added with this change is failing on iOS: > > > > TestWTF.WTF_ListHashSet.UniquePtrKey_InsertBeforeUsingRawPointer > > > > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > > WTF/ListHashSet.cpp:453 > > Expected equality of these values: > > ptrWith2 > > Which is: 0x7faee4f03c90 > > firstWith4.get() > > Which is: 0x7faee4f03ca0 > > > > https://build.webkit.org/builders/ > > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/1130/steps/ > > run-api-tests/logs/stdio > Oh, I think this was fixed in https://trac.webkit.org/changeset/238486/webkit Yeah, I fixed it already.

Note You need to log in before you can comment on or make changes to this bug.