Summary: | [ews-app] Add support to communicate with Buildbot | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Aakash Jain
2018-11-23 17:57:32 PST
Created attachment 355550 [details]
Proposed patch
Part of patch series. Therefore wouldn't apply to ToT without applying other patches first.
Comment on attachment 355550 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44 > + _log.warn('Error in executing: {}, rc={}'.format(command, return_code)) This should be: Error executing: or Error while executing: Comment on attachment 355550 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355550&action=review > Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:35 > + command = ['buildbot', 'try', '--connect=pb', '--master={}:{}'.format(config.BUG_SERVER_HOST, config.BUILDBOT_SERVER_PORT), nit: Have every `--flag [param]` pair be in it's own new line for readability. >> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:44 >> + _log.warn('Error in executing: {}, rc={}'.format(command, return_code)) > > This should be: > Error executing: > or > Error while executing: nit: spell out `rc` => `return code` and have it be on a new line. > nit: > Have every `--flag [param]` pair be in it's own new line for readability. Sure. > nit: spell out `rc` => `return code` Done > and have it be on a new line. Tried with and without new line, having on same line seems more readable. > > This should be: > > Error executing: Changed. Committed r238535: <http://trac.webkit.org/changeset/238535> |