Bug 19192

Summary: remove NPNVpluginEventModel, fix example plugin
Product: WebKit Reporter: Josh Aas <joshmoz>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
fix v1.0
none
fix v1.1 andersca: review+

Josh Aas
Reported 2008-05-22 08:29:30 PDT
There is really no reason for anyone to get the NPNVpluginEventModel variable, the plugin should know it and it gives the illusion that there could be some disagreement with its NPPV sibling. Its existence is confusing and leads to bugs like the Cocoa event plugin mistakenly using it in a SetValue call.
Attachments
fix v1.0 (2.16 KB, patch)
2008-05-22 08:30 PDT, Josh Aas 		no flags
DetailsFormatted DiffDiff
fix v1.1 (3.18 KB, patch)
2008-05-22 08:32 PDT, Josh Aas 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Josh Aas
Comment 1 2008-05-22 08:30:11 PDT
Created attachment 21293 [details] fix v1.0
Josh Aas
Comment 2 2008-05-22 08:32:52 PDT
Created attachment 21294 [details] fix v1.1 Also fix the drawing models plugin.
Anders Carlsson
Comment 3 2008-05-22 11:17:11 PDT
<rdar://problem/5956429>
Anders Carlsson
Comment 4 2008-05-22 11:28:53 PDT
Comment on attachment 21294 [details] fix v1.1 Needs a ChangeLog, but I took care of that.
Anders Carlsson
Comment 5 2008-05-22 11:29:02 PDT
Committed revision 34026.
Note You need to log in before you can comment on or make changes to this bug.