Bug 191913

Summary: Address post-review feedback after r238438
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+
Try to fix Win build none

Wenson Hsieh
Reported 2018-11-22 12:09:07 PST
• Make Editor::setSelectedRange take enum classes instead of bools. • Make Editor::replaceSelectionWithText take enum classes instead of bools. • Don't pass in Vector&&s for a few functions that don't take ownership of the Vector. • ...and a couple of other small items.
Attachments
Patch (40.50 KB, patch)
2018-11-22 16:24 PST, Wenson Hsieh 		rniwa: review+
DetailsFormatted DiffDiff
Try to fix Win build (41.81 KB, patch)
2018-11-22 17:22 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-11-22 12:36:41 PST
(In reply to Wenson Hsieh from comment #0) > • Make Editor::setSelectedRange take enum classes instead of bools. I meant to write `FrameSelection::setSelectedRange`. > • Make Editor::replaceSelectionWithText take enum classes instead of bools. > • Don't pass in Vector&&s for a few functions that don't take ownership of > the Vector. > • ...and a couple of other small items.
Wenson Hsieh
Comment 2 2018-11-22 16:24:14 PST
Created attachment 355491 [details] Patch
Wenson Hsieh
Comment 3 2018-11-22 17:22:19 PST
Created attachment 355494 [details] Try to fix Win build
WebKit Commit Bot
Comment 4 2018-11-22 19:10:41 PST
Comment on attachment 355494 [details] Try to fix Win build Clearing flags on attachment: 355494 Committed r238454: <https://trac.webkit.org/changeset/238454>
Radar WebKit Bug Importer
Comment 5 2018-11-22 19:11:32 PST
<rdar://problem/46216836>
Note You need to log in before you can comment on or make changes to this bug.