Bug 191904 – [GStreamer][WebRTC] Do not run device monitor for device type we do not handle

• Component: New Bugs
• Status: RESOLVED FIXED

[Thibault Saunier]

[GStreamer][WebRTC] Do not run device monitor for device type we do not handle

[Thibault Saunier]

Created attachment 355468 [details]
Minor ChangeLog enhancement

[Philippe Normand]

Comment on attachment 355468 [details]
Minor ChangeLog enhancement

View in context: https://bugs.webkit.org/attachment.cgi?id=355468&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113
> +        } else {
> +            return;
>          }

The curly braces can be removed :)

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112
> -        // FIXME: Add monitor for added/removed messages on the bus.

Why is this removed? Doesn't need to be fixed?

[Thibault Saunier]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 355468 [details]
> Minor ChangeLog enhancement
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355468&action=review
> 
> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113
> > +        } else {
> > +            return;
> >          }
> 
> The curly braces can be removed :)

Done.

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112
> > -        // FIXME: Add monitor for added/removed messages on the bus.
> 
> Why is this removed? Doesn't need to be fixed?

Right, just moving it and forgot to commit the addition. Re added now.

[Thibault Saunier]

Created attachment 355758 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355758 [details]
Patch

Clearing flags on attachment: 355758

Committed r238605: <https://trac.webkit.org/changeset/238605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46306708>