Bug 191896

Summary:

[LFC] LayoutState should always be initialized with the initial containing block.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description zalan 2018-11-21 14:36:00 PST

and not with some random formatting context root.

Comment 1 zalan 2018-11-21 14:52:09 PST

Created attachment 355440 [details]
Patch

Comment 2 Antti Koivisto 2018-11-21 15:12:10 PST

Comment on attachment 355440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355440&action=review

> Source/WebCore/layout/Verification.cpp:324
> +    auto& initialContainingBlock = *m_initialContainingBlock;

The local here doesn't do much.

Comment 3 zalan 2018-11-21 15:25:19 PST

Committed r238431: <https://trac.webkit.org/changeset/238431>

Comment 4 Radar WebKit Bug Importer 2018-11-21 15:26:29 PST

<rdar://problem/46205042>